Skip to content

update attributes for psm3-tmy to match the lk script#1023

Merged
brtietz merged 2 commits into
patchfrom
fix_sam_1022_nsrdb_psm_tmy3
Apr 29, 2022
Merged

update attributes for psm3-tmy to match the lk script#1023
brtietz merged 2 commits into
patchfrom
fix_sam_1022_nsrdb_psm_tmy3

Conversation

@brtietz

@brtietz brtietz commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Queries to psm3-tmy were coming back with no timezone information. When I tried the query in a browser, I got the following error:

image

Remove the problematic attrs, which now matches the lk script for the quick download.

Fixes #1022

To test:

  • Build SAM and SAM-private
  • Download a psm3-tmy file
  • The downloaded file has a timezone

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@brtietz brtietz added this to the 2021.12.02 Patch 2 milestone Apr 28, 2022
@brtietz brtietz requested a review from cpaulgilman April 28, 2022 21:39
@brtietz brtietz added the bug label Apr 28, 2022
@cpaulgilman

Copy link
Copy Markdown
Collaborator

This fix is consistent with the NSRDB API documentation for the psm3-tmy endpoint showing that clearsky attributes are not available: https://developer.nrel.gov/docs/solar/nsrdb/psm3-tmy-download/

Other endpoints, such as psm3 have clearsky attributes that we want to include when available to address this SSC issue: NatLabRockies/ssc#151

This ensures that time zone is local
@cpaulgilman

Copy link
Copy Markdown
Collaborator

When a call to the NSRDB fails, SAM tries a second call with no attributes in case the attribute list was incorrect. The reason the psm3-tmy call with incorrect attributes returned a file with UTC time zone is because the subsequent call with no attributes did not include the UTC parameter. That is fixed in 8593030.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good after my commit adding the UTC attribute to the second API call.

@brtietz brtietz merged commit f8c1813 into patch Apr 29, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
@cpaulgilman cpaulgilman deleted the fix_sam_1022_nsrdb_psm_tmy3 branch October 20, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSRDB advanced download sets time zone to 0 for full-disc and typical year

2 participants