Update Solar Resource File Converter.lk#1019
Merged
Merged
Conversation
adjusts minute values to match the center of the interval for more accurate solar position calculations. Moving by 1/2 of of the time step since SolarAnywhere timestamps have minutes corresponding to the beginning of the interval.
cpaulgilman
approved these changes
May 20, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
@williamhobbs Thanks for this fix. It broke the method the macro was using to identify files with multi-year data, but I fixed that in my latest commit.
Collaborator
|
Fix #1016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I modified the solar resource file converter macro to move minutes in SolarAnywhere data to the middle of the interval instead of the beginning.
Fixes #1016.
I don't think any changes to documentation are required. And I'm not sure what testing is required - I was able to run the modified macro with 60min and 15min SolarAnywhere files and got the expected result.
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.