Warn if trying to run a ReportingMmeasure that has an overridden modelOutputRequests #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmarrec
commented
Mar 20, 2025
- cf #4830 - Add a new ReportingMeasure::modelOutputRequests(model, runner, argument_map) that runs before E+ FT OpenStudio#5367
19 tasks
jmarrec
commented
Mar 20, 2025
Comment on lines
+477
to
+486
|
|
||
| # Just in case this workflow-gem is used (via bundle) in an | ||
| # older OS SDK version, where the base class doesn't have it, | ||
| # we check for existence to begin with | ||
| if measure_object.respond_to?(:modelOutputRequests) | ||
| # If there is an overidden method in the measure itself: Warn | ||
| if measure_object.method(:modelOutputRequests).owner == measure_object.class | ||
| logger.error "Reporting Measure at '#{measure_path}' has a 'modelOutputRequests' method, but that is only available in the C++ CLI, it will NOT be run." | ||
| end | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Before running the energyPlusOutputRequests, check if there is an overriden modelOutputRequests and just log an error saying it's not going to be run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.