Pull request overview

• Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades OpenStudio#5384
• DesignSpecification:OutdoorAir:SpaceList does not work with Controller:MechanicalVentilation EnergyPlus#11018

Link to the Ubuntu 22.04 .deb installer to use for CI Testing. If not set, it will default to latest official release.
[OpenStudio Installer]: http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/PR-5384/OpenStudio-3.10.0-alpha%2Bf1f36e141c-Ubuntu-22.04-x86_64.deb

This Pull Request is concerning:

• Case 3 - NewTestForExisting: a new test for an already-existing model API class

Case 3: New test for an already-existing model API class

This adds a test for #5384

Work Checklist

The following has been checked to ensure compliance with the guidelines:

• Test has been run backwards (see Instructions for Running Docker) for all OpenStudio versions

• A Matching OSM test has been added with the output of the ruby test for the oldest OpenStudio release where it passes (include OpenStudio Version)

• Ruby test is stable in the last OpenStudio version: when run multiple times on the same machine, it produces the same total site kBTU.

  • I ensured that I assign systems/loads/etc in a repeatable manner (eg: if I assign stuff to thermalZones, I do model.getThermalZones.sort_by{|z| z.name.to_s}.each do ... so I am sure I put the same ZoneHVAC systems to the same zones regardless of their order)
  • I tested stability using process_results.py (see python process_results.py --help for usage).
    Please paste the text output or heatmap png generated after running the following commands:

    # Clean up all custom-tagged OSWs
    python process_results.py test-stability clean
    # Run your test 5 times in a row. Replace `testname_rb` (eg `airterminal_fourpipebeam_rb`)
    python process_results.py test-stability run -n testname_rb
    # Check that they all passed
    python process_results.py test-status --tagged
    # Check site kBTU differences
    python process_results.py heatmap --tagged
    

• Object has been added to autosize_hvac.rb to ensure the autosizedXXX values methods do work

Case 4: Other

Please be as explicit as possible about the changes you have made, and why they are warranted.

Review Checklist

• Code style (indentation, variable names, strip trailing spaces)
• Functional code review (it has to work!)
• Matching OSM test has been added or # TODO added to model_tests.rb
• Appropriate out.osw have been committed
• Test is stable
• Object is tested in autosize_hvac as appropriate
• The appropriate labels have been added to this PR:
  • One of: NewTest, TestFix, NewTestForExisting, Other
  • If NewTest: add PendingOSM or AddedOSM