new labs MeasureManager #267
Conversation
|
@kbenne, that change fixed the issue! everything looks good now I think! |
|
Cool. We'll keep "MeasureManager Ready". I put that in there because I expected it would be easy for you to parse as it doesn't include any variable text like the hostname or the port. Thanks for working through this with me! |
|
Thank you @jmarrec for doing all of the heavy lifting on the OpenStudio side. |
|
thank you both! |
| vm.$log.info('Start Measure Manager Server: ', vm.cliPath, ' measure -s ', vm.port); | ||
| vm.cli = vm.spawn(vm.cliPath, ['measure', '-s', vm.port]); | ||
| vm.$log.info('Start Measure Manager Server: ', vm.cliPath, 'labs measure -s ', vm.port); | ||
| let the_cmd = vm.cliPath + ' labs'; |
There was a problem hiding this comment.
I'm on my phone so could be wrong but this looks unused.
|
Hi all, since we are keeping use |
|
maybe let's leave it here until we decided to update from classic in the future? |
|
Of course do what you please, but I'd still like to ask you consider switching as early as possible on dev in the release cycle so that you at least have some amount of people trying it out and reporting issues they may encounter, so we have plenty of time to calmy address whatever comes up (and not rush between release candidate and official) Alternatively you can make a runtime setting (a bool toggle) to allow changing between classic and labs. That's what I've done on OpenStudio Application |
|
@jmarrec Kat has been voluntering her time so far. @DavidGoldwasser I second what Julien is saying. It would be helpful to have this switch happening now while we are early in the release cycle. |
|
I totally agree @jmarrec! |
|
It would be great if we can merge to develop in January. The Ruby 3.2 upgrade will also have impacts to PAT through Analysis Gem. |
|
@wenyikuang this is probably needed for 3.8.0? |
|
|
closing this as #284 is merged |
PAT updates for new labs MeasureManager
now starting measure manager with the following command:
openstudio labs measure -s <port number>Ready to merge when you want to use this new MeasureManager!
works with openstudio starting with this version.