Add macOS build improvements #5575
Conversation
🧪 Test Results DashboardSummary
✅ All Tests Passed!📊 Test Run Information
|
…library reference for macOS
…G executable in incremental build
|
CI Results for 5db1739:
|
| -DBUILD_PYTHON_BINDINGS:BOOL=ON \ | ||
| -DBUILD_PYTHON_PIP_PACKAGE:BOOL=OFF \ | ||
| -DCMAKE_INSTALL_RPATH="@loader_path;@executable_path" \ | ||
| -DCMAKE_INSTALL_RPATH="@loader_path;@executable_path;@loader_path/../lib" \ |
There was a problem hiding this comment.
Is this for #5574 ?
This is the wrong solution IMHO. This should be done in cmakelists, not via a command line parameter (which anyone building is likely to forget to add).
There was a problem hiding this comment.
It could be that #5574 exists is because you are passing this variable CMAKE_INSTALL_RPATH to begin with (or something similar). In any case I don't think we want to do that.
We never explicitly added libopenstudiolib.dylib into the openstudio.bundle and it has always worked fine, until the full-build workflow was added.
$ otool -L /Applications/OpenStudio-3.10.0/Ruby/openstudio.bundle
/Applications/OpenStudio-3.10.0/Ruby/openstudio.bundle:
/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 61439.101.1)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 3423.0.0)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1900.178.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1351.0.0)
$ otool -L /Applications/OpenStudio-3.11.0-rc2/Ruby/openstudio.bundle
/Applications/OpenStudio-3.11.0-rc2/Ruby/openstudio.bundle:
@rpath/libopenstudiolib.dylib (compatibility version 0.0.0, current version 0.0.0)
/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 61439.120.27)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 3502.1.255)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1900.180.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1351.0.0)
Should track where this started popping.
There was a problem hiding this comment.
I don't get why passing CMAKE_INSTALL_RPATH, seems to be stemming from 40d0625 and the commit message doesn't explain anything
There was a problem hiding this comment.
I see that you made a PR #5583 to fix this so that CMAKE_INSTALL_RPATH is no longer provided.
Enhance the CMake build configuration for macOS by adding the macOS version specification and updating the installation RPATH to include the library path. This ensures better compatibility and functionality for macOS bundles.