Fix #5544 - Do not Warn about adding a GenericModelObject for CommentOnly #5545
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Test Results DashboardSummary
|
| Run | XML File | Status |
|---|---|---|
| run1 | results.xml |
✅ Found |
| run3 | results.xml |
✅ Found |
| run2 | results.xml |
✅ Found |
```
[ RUN ] ModelFixture.Model_nowarn_GenericModelObject_CommentOnly
/Users/julien/Software/Others/OpenStudio/src/model/test/Model_GTest.cpp:1217: Failure
Expected equality of these values:
0
sink.logMessages().size()
Which is: 1
Expected zero log messages but found 1: [openstudio.model.Model] <0> Creating GenericModelObject for IddObjectType 'CommentOnly'.
```
97c04c7 to
145f467
Compare
jmarrec
commented
Dec 8, 2025
Comment on lines
+1215
to
+1217
| sink.setLogLevel(Warn); | ||
| EXPECT_TRUE(m.addObject(i)); | ||
| EXPECT_EQ(0, sink.logMessages().size()) << "Expected zero log messages but found " << sink.logMessages().size() << ": " << sink.string(); |
Collaborator
Author
There was a problem hiding this comment.
Before fix there is 1 Warning
[ RUN ] ModelFixture.Model_nowarn_GenericModelObject_CommentOnly
/Users/julien/Software/Others/OpenStudio/src/model/test/Model_GTest.cpp:1217: Failure
Expected equality of these values:
0
sink.logMessages().size()
Which is: 1
Expected zero log messages but found 1: [openstudio.model.Model] <0> Creating GenericModelObject for IddObjectType 'CommentOnly'.
Comment on lines
+159
to
+161
| if (object.iddObject().type().value() != IddObjectType::CommentOnly) { | ||
| LOG(Warn, "Creating GenericModelObject for IddObjectType '" << object.iddObject().type().valueName() << "'."); | ||
| } |
joseph-robertson
approved these changes
Dec 8, 2025
Collaborator
joseph-robertson
left a comment
There was a problem hiding this comment.
LGTM. Only log warning when creating object not of IddObjectType "CommentOnly". And a new test, nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.