Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Oct 24, 2025

Pull request overview

TODO: mac packages are unavailable on the E+ release page right now. Will need to add them once they are.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Oct 24, 2025
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 24, 2025
Comment on lines +651 to +654
set(ENERGYPLUS_EXPECTED_HASH TDB_TODO_TBD_CODESIGN_FAILURE_DUE_TO_OUTDATED_APPLE_LICENSE_AGREEMENT)
set(ENERGYPLUS_PLATFORM "Darwin-macOS13-arm64")
else()
set(ENERGYPLUS_EXPECTED_HASH 7c01999d5a840168c9bfbfad912794b9)
set(ENERGYPLUS_EXPECTED_HASH TDB_TODO_TBD_CODESIGN_FAILURE_DUE_TO_OUTDATED_APPLE_LICENSE_AGREEMENT)
Copy link
Collaborator Author

@jmarrec jmarrec Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-robertson joseph-robertson merged commit 96221b6 into develop Oct 24, 2025
2 of 6 checks passed
@joseph-robertson joseph-robertson deleted the update_to_v2520IO-RC2 branch October 24, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants