Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Oct 23, 2025

Pull request overview

Outside of scope was filed at:

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Oct 23, 2025
@jmarrec jmarrec added component - HVAC component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Oct 23, 2025
@jmarrec
Copy link
Collaborator Author

jmarrec commented Oct 23, 2025

EUI diffs for dsn_oa_w_ideal_loads, ideal_loads_w_plenum and surface_properties_ground_and_solarmult are gone with this PR. Will drop it as soon as CI says it's ok.

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 23, 2025

CI Results for 64a0820:

@jmarrec jmarrec merged commit fdb1047 into develop Oct 23, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the ideal_dsoa branch October 23, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - HVAC component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants