V25.2.0-IOFreeze: new SizingZone and SizingSystem fields #5491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Collaborator
|
CI Results for 862e86c:
|
jmarrec
approved these changes
Oct 20, 2025
Collaborator
jmarrec
left a comment
There was a problem hiding this comment.
Straigthforward enough, LGTM
Comment on lines
+28668
to
+28692
| A13, \field Heating Coil Sizing Method | ||
| \note Size a heat pump heating coil using the Cooling, Heating or GreaterOfHeatingOrCooling capacities | ||
| \type choice | ||
| \key None | ||
| \key CoolingCapacity | ||
| \key HeatingCapacity | ||
| \key GreaterOfHeatingOrCooling | ||
| \required-field | ||
| N28; \field Maximum Heating Capacity To Cooling Capacity Sizing Ratio | ||
| \note The limit of heating coil capacity to cooling coil capacity | ||
| \type real | ||
| \units W/W | ||
| \minimum 1.0 | ||
| \required-field |
Collaborator
There was a problem hiding this comment.
default None and default 1 in E+ IDD.
Changed to required-field, I like it so far
Comment on lines
+28955
to
+28977
| A14,\field Heating Coil Sizing Method | ||
| \type choice | ||
| \key None | ||
| \key CoolingCapacity | ||
| \key HeatingCapacity | ||
| \key GreaterOfHeatingOrCooling | ||
| \required-field | ||
| N27;\field Maximum Heating Capacity To Cooling Load Sizing Ratio | ||
| \type real | ||
| \units W/W | ||
| \minimum 1.0 | ||
| \required-field |
Comment on lines
+975
to
+977
| // New E+ 25.2.0 fields, IDD defaults | ||
| setHeatingCoilSizingMethod("None"); | ||
| setMaximumHeatingCapacityToCoolingLoadSizingRatio(1.0); |
Comment on lines
+1124
to
+1125
| setHeatingCoilSizingMethod("None"); | ||
| setMaximumHeatingCapacityToCoolingCapacitySizingRatio(1.0); |
| static std::vector<std::string> zoneLatentCoolingDesignSupplyAirHumidityRatioInputMethodValues(); | ||
| static std::vector<std::string> zoneLatentHeatingDesignSupplyAirHumidityRatioInputMethodValues(); | ||
| static std::vector<std::string> validSizingOptionValues(); | ||
| static std::vector<std::string> heatingCoilSizingMethodValues(); |
|
|
||
| static std::vector<std::string> validSystemOutdoorAirMethodValues(); | ||
|
|
||
| static std::vector<std::string> heatingCoilSizingMethodValues(); |
src/osversion/VersionTranslator.cpp
Outdated
Comment on lines
9780
to
9782
| m_refactored.push_back(RefactoredObjectData(object, newObject)); | ||
| ss << newObject; | ||
|
|
Collaborator
There was a problem hiding this comment.
same stuff as I said on 4 PRs already, emplace_back + move, will fix it myself.
Comment on lines
+349
to
+359
| // Heating Coil Sizing Method | ||
| s = modelObject.heatingCoilSizingMethod(); | ||
| if (s) { | ||
| idfObject.setString(Sizing_ZoneFields::HeatingCoilSizingMethod, s.get()); | ||
| } | ||
|
|
||
| // Maximum Heating Capacity To Cooling Load Sizing Ratio | ||
| value = modelObject.maximumHeatingCapacityToCoolingLoadSizingRatio(); | ||
| if (value) { | ||
| idfObject.setDouble(Sizing_ZoneFields::MaximumHeatingCapacityToCoolingLoadSizingRatio, value.get()); | ||
| } |
Collaborator
There was a problem hiding this comment.
neither are optional, and it's a waste to go through an optional, but at least this is consistent with the rest of the file. I've got enough stuff to do to not go and refactor the whole file right now.
862e86c to
d731b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.