Skip to content

Fix #5473 - Add missing convenience methods for HotWaterEquipment in Space, SpaceType, ThermalZone and Building #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmarrec merged 7 commits into from
Oct 22, 2025
Merged

Fix #5473 - Add missing convenience methods for HotWaterEquipment in Space, SpaceType, ThermalZone and Building #5480

jmarrec merged 7 commits into from
Oct 22, 2025

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Aug 27, 2025 •
edited
Loading

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Model API methods are tested (in src/model/test)

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Aug 27, 2025
@jmarrec jmarrec added component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Aug 27, 2025
@jmarrec
#5473 - Add HotWaterEquipment convenience methods to Space
e7c9fbf
@jmarrec
#5473 - Add convenience getters in HotWaterEquipment to query the def…
1e120c5 
…inition

To match ElectricEquipment, GasEquipment, etc
@jmarrec
#5473 - Add HotWaterEquipment convenience methods to SpaceType (don't…
5888428 
… like them)

Note that I dislike the getters such as hotWaterEquipmentPowerPerFloorArea, hotWaterEquipmentPowerPerPerson because they just query the equipment instnaces on the space type and work only if they are ALL PerFloorArea/PerPerson.

I think it would be more useful if they looped on SpaceType::spaces() and would sum the hotWaterEquipmentPowerPerPerson (times the multiplier).

But I'm matching the other SpaceLoadInstances (GasEquipment, ElecttricEquipment, etc)
@jmarrec
#5473 - Add HotWaterEquipment convenience methods to ThermalZone
81c4e33
@jmarrec
#5473 - Add HotWaterEquipment convenience methods to Building
e1ddcdd
@jmarrec
Add (type-parametrized) testing for convenience methods for Lights, E…
086cbda 
…lec, Gas, and Hot Water Equipment
@jmarrec
clang format
1607b35
@jmarrec jmarrec force-pushed the 5473_hotWaterEquipmentPower branch from 7f95dd9 to 1607b35 Compare October 20, 2025 12:11
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 20, 2025 •
edited
Loading

CI Results for 1607b35:

@jmarrec
Copy link
Collaborator Author

jmarrec commented Oct 22, 2025

Been opened for 2 months, and I'm quite positive about my changes and tests, dropping it in.

@jmarrec jmarrec merged commit f7a9425 into develop Oct 22, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the 5473_hotWaterEquipmentPower branch October 22, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseph-robertson joseph-robertson Awaiting requested review from joseph-robertson

Assignees

@jmarrec jmarrec

Labels

component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Space convenience methods for HotWaterEquipment

3 participants

@jmarrec @ci-commercialbuildings