-
Notifications
You must be signed in to change notification settings - Fork 222
V25.2.0-IOFreeze: HeatPumpAirToWaterFuelFired's new fields #5478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI Results for 4cf2b99:
|
jmarrec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, straightforward
| N14;\field Minimum Unloading Ratio | ||
| \minimum 0 | ||
| \maximum 1 | ||
| \required-field | ||
| \note Minimum modulation level of the gas-fired heat pump. Typically less than 1.0 and slightly higher than the minimum part load ratio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, both objects are getting a new field, E+ default is 0.25
| ok = setMinimumUnloadingRatio(0.25); | ||
| OS_ASSERT(ok); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, all good, required, one non opt getter + one setter only.
| ok = setMinimumUnloadingRatio(0.25); | ||
| OS_ASSERT(ok); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two ctors total, both getting the default, ok
4cf2b99 to
a5d2233
Compare
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.