Skip to content

Conversation

@anchapin
Copy link
Collaborator

@anchapin anchapin commented Jun 24, 2025

The workflow runs on push events, executes on Windows runners, and includes steps to check out the repository and verify the presence of build tools (conan, cmake, ninja).

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

anchapin added 2 commits June 24, 2025 15:08
The workflow runs on push events, executes on Windows runners, and includes steps to check out the repository and verify the presence of build tools (conan, cmake, ninja).
Add ExecutionPolicy Bypass setting to ensure PowerShell scripts can run properly in the Windows CI workflow environment.
@anchapin anchapin changed the title Add Windows GitHub workflow for testing measure gems Add Windows GitHub workflow for testing self-hosted runner Jun 24, 2025
anchapin added 4 commits June 24, 2025 15:18
Use pwsh with inline execution policy setting instead of separate command to streamline the workflow and ensure consistent execution policy handling.
The change replaces the PowerShell execution policy bypass with a simpler cmd shell for running the conan version check in the Windows workflow.
Add new GitHub Actions workflow for macOS self-hosted runners with basic tool version checks. Update Windows workflow name to "Test Self-hosted Runner" for consistency.
@anchapin anchapin changed the title Add Windows GitHub workflow for testing self-hosted runner Add Windows & MaxGitHub workflow for testing self-hosted runner Jun 24, 2025
@anchapin anchapin changed the title Add Windows & MaxGitHub workflow for testing self-hosted runner Add Windows & Mac GitHub workflow for testing self-hosted runner Jun 24, 2025
anchapin added 2 commits June 24, 2025 15:36
Change the shell type from cmd to bash for the test command step in the macOS CI workflow, which better aligns with the macOS environment.
AI: I've generated a concise commit message that describes the change - removing the ninja version check command from the Windows GitHub workflow. The message is in imperative mood, under the character limit, and clearly states what was changed.
@anchapin anchapin merged commit f24a72f into develop Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants