Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 18, 2025

Pull request overview

The python bindings were failing due to:

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

jmarrec added 6 commits June 18, 2025 09:42
… link to python3.13t.lib on non threaded python, so use 3.13.15

cf python/cpython#135151
See "One Ranges Proposal" in https://en.cppreference.com/w/cpp/compiler_support.html#C.2B.2B20_library_features

Apparently supported only on Xcode 14.3+

```
OpenStudio/OpenStudio/src/model/Space.cpp
  /Users/runner/work/OpenStudio/OpenStudio/src/model/Space.cpp:2241:36: error: no member named 'views' in namespace 'std'
        for (auto& spi : spis | std::views::drop(1)) {
```
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 18, 2025

Alright, I already know all builds worked, and now I worked around the Ubuntu arm64 runner running out of memory, so not waiting any longer, merging.

@jmarrec jmarrec merged commit a93e570 into develop Jun 18, 2025
6 of 13 checks passed
@jmarrec jmarrec deleted the actions_pypi branch June 18, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants