Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 17, 2025

Pull request overview

I haven't had time to check that it ends up in the tar.gz/.dmg correctly though.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Jun 17, 2025
@jmarrec jmarrec added severity - Normal Bug component - Installer/Platform Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Jun 17, 2025
@jmarrec jmarrec changed the title Fix #5435 - copy cpprestsdk_char_traits_workaround to buld_dir/src so it's automatically included Fix #5435 - copy cpprestsdk_char_traits_workaround to build_dir/src so it's automatically included Jun 17, 2025
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Jun 17, 2025

@jmarrec jmarrec requested review from anchapin, kbenne and tijcolem June 17, 2025 14:38
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 17, 2025

Can't test the mac package with OSApp because CI is forever broken.

Based on some testing I've done on linux, it appears fine. I do see it inside the package at include/openstudio/cpprestsdk_char_traits_workaround.hpp

Merging.

@jmarrec jmarrec merged commit c0a1dd7 into develop Jun 17, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the 5435_cpprestsdk_workaround_install branch June 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - Installer/Platform Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Normal Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpprestsdk_char_traits_workaround.hpp isn't shipped in install package, preventing to build against OS SDK 3.10.0-rc5

3 participants