Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 2, 2025

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

… issue when we pip install stuff into the E+ dir with native comps (numpy for eg)
@jmarrec jmarrec requested a review from anchapin June 2, 2025 09:11
@jmarrec jmarrec self-assigned this Jun 2, 2025
@jmarrec jmarrec added Developer Issue component - CLI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Jun 2, 2025
Comment on lines 646 to +650
if(APPLE)

# TODO: temp for #5281 - Resigned with a different entitlements to avoid an issue when we pip install stuff into the E+ dir with native comps (numpy for eg)
set(ENERGYPLUS_REPO "jmarrec")
set(ENERGYPLUS_RELEASE_NAME "v25.1.0-WithDSOASpaceListFixes-python-entitlements")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now on Apple, pull from new release on my fork
https://github.com/jmarrec/EnergyPlus/releases/tag/v25.1.0-WithDSOASpaceListFixes-python-entitlements

Might be able to hot swap the binaries on the E+ release https://github.com/NREL/EnergyPlus/releases/tag/v25.1.0-WithDSOASpaceListFixes later today. Want the blessing of @Myoldmopar before I do.

@anchapin
Copy link
Collaborator

anchapin commented Jun 2, 2025

@jmarrec This change seems like a necessary step for the time being. At least until the code signing issue is addressed. I reran the failing Ubuntu builds to see if those errors will go away. If so, I'll merge this PR.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 2, 2025

@jmarrec This change seems like a necessary step for the time being. At least until the code signing issue is addressed. I reran the failing Ubuntu builds to see if those errors will go away. If so, I'll merge this PR.

this PR only pulls updated E+ packages for mac; The ubuntu incremental failures are totally unrelated (just a ruby/bundle configuration issue most likely).

@anchapin anchapin merged commit bf45754 into develop Jun 2, 2025
4 of 6 checks passed
@jmarrec jmarrec deleted the python-entitlements branch June 3, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - CLI Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants