Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 27, 2025

Pull request overview

Locally I get 100% of the bundle tests passing on Ubunut. If CI is failing on Ubuntu, it's a CI configuration issue @anchapin @tijcolem

$ ctest -R "CLITest-test_bundle" -j 16
Test project /media/DataExt4/Software/Others/OS-build-release3
    Start 4021: CLITest-test_bundle-bundle
    Start 4024: CLITest-test_bundle-bundle_native_embedded
    Start 4022: CLITest-test_bundle-bundle_git
    Start 4027: CLITest-test_bundle-bundle_default
    Start 4025: CLITest-test_bundle-bundle_no_install
    Start 4023: CLITest-test_bundle-bundle_native
    Start 4026: CLITest-test_bundle-no_bundle
1/7 Test #4023: CLITest-test_bundle-bundle_native ............   Passed   17.21 sec
2/7 Test #4025: CLITest-test_bundle-bundle_no_install ........   Passed   20.30 sec
3/7 Test #4026: CLITest-test_bundle-no_bundle ................   Passed   22.40 sec
4/7 Test #4027: CLITest-test_bundle-bundle_default ...........   Passed   22.81 sec
5/7 Test #4022: CLITest-test_bundle-bundle_git ...............   Passed   32.00 sec
6/7 Test #4021: CLITest-test_bundle-bundle ...................   Passed   32.65 sec
7/7 Test #4024: CLITest-test_bundle-bundle_native_embedded ...   Passed   32.69 sec


### Pull Request Author

<!--- Add to this list or remove from it as applicable.  This is a simple templated set of guidelines. -->

 - [ ] Model API Changes / Additions
 - [ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
 - [ ] Model API methods are tested (in `src/model/test`)
 - [ ] EnergyPlus ForwardTranslator Tests (in `src/energyplus/Test`)
 - [ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
 - [ ] If needed, added VersionTranslation rules for the objects (`src/osversion/VersionTranslator.cpp`)
 - [ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
 - [ ] All new and existing tests passes
 - [ ] If methods have been deprecated, update rest of code to use the new methods

**Labels:**

 - [ ] If change to an IDD file, add the label `IDDChange`
 - [ ] If breaking existing API, add the label `APIChange`
 - [ ] If deemed ready, add label `Pull Request - Ready for CI` so that CI builds your PR

### Review Checklist

This will not be exhaustively relevant to every PR.
 - [ ] Perform a Code Review on GitHub
 - [ ] Code Style, strip trailing whitespace, etc.
 - [ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
 - [ ] Labeling is ok
 - [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
 - [ ] If feature, test running new feature, try creative ways to break it
 - [ ] CI status: all green or justified

@jmarrec jmarrec self-assigned this May 27, 2025
@jmarrec jmarrec added Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels May 27, 2025
@jmarrec jmarrec requested review from anchapin and tijcolem May 27, 2025 08:35
@jmarrec jmarrec merged commit 106e75c into develop May 27, 2025
3 of 6 checks passed
@jmarrec jmarrec deleted the fix_bundle_bundle branch May 27, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants