Fix #5397 - Controller:MechanicalVentilation should not inherit SizingSystem's OA Method if option isn't common to both #5414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Note: Google Test filter = ModelFixture.ControllerMechanicalVentilation_SystemOutdoorAirMethod
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ModelFixture
[ RUN ] ModelFixture.ControllerMechanicalVentilation_SystemOutdoorAirMethod
/media/DataExt4/Software/Others/OpenStudio3/src/model/test/ControllerMechanicalVentilation_GTest.cpp:64: Failure
Expected equality of these values:
"Standard62.1VentilationRateProcedure"
controller_mv.systemOutdoorAirMethod()
Which is: "Standard62.1SimplifiedProcedure"
[ FAILED ] ModelFixture.ControllerMechanicalVentilation_SystemOutdoorAirMethod (8 ms)
[----------] 1 test from ModelFixture (8 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (9 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ModelFixture.ControllerMechanicalVentilation_SystemOutdoorAirMethod
```
…gSystem's OA Method if not common option
jmarrec
commented
May 27, 2025
Comment on lines
+61
to
+64
| // System Outdoor Air Method is NOT common to both ControllerMechanicalVentilation and SizingSystem | ||
| EXPECT_TRUE(sz.setSystemOutdoorAirMethod("Standard62.1SimplifiedProcedure")); | ||
| EXPECT_TRUE(controller_mv.isSystemOutdoorAirMethodDefaulted()); | ||
| EXPECT_EQ("Standard62.1VentilationRateProcedure", controller_mv.systemOutdoorAirMethod()); |
Collaborator
Author
There was a problem hiding this comment.
Before fix
[ RUN ] ModelFixture.ControllerMechanicalVentilation_SystemOutdoorAirMethod
/media/DataExt4/Software/Others/OpenStudio3/src/model/test/ControllerMechanicalVentilation_GTest.cpp:64: Failure
Expected equality of these values:
"Standard62.1VentilationRateProcedure"
controller_mv.systemOutdoorAirMethod()
Which is: "Standard62.1SimplifiedProcedure"
Comment on lines
+112
to
+118
| const auto sizingSystemOAMethod = airLoop->sizingSystem().systemOutdoorAirMethod(); | ||
| const auto possible_vals = systemOutdoorAirMethodValues(); | ||
| if (std::find_if(possible_vals.cbegin(), possible_vals.cend(), | ||
| [&sizingSystemOAMethod](const std::string& val) { return openstudio::istringEqual(val, sizingSystemOAMethod); }) | ||
| != possible_vals.cend()) { | ||
| result = sizingSystemOAMethod; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Simple fix: do not inherit the SizingSystem's System Outdoor Air Method value if this option isn't one available in Controller:MV.
Collaborator
|
CI Results for 81f6540:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.