#5398 - Workarounds to let OpenStudio build with recent clang #5400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang has a new warning that requires a template argument list after using the template keyword. See llvm/llvm-project#94194 for the upstream clang changes ``` /Users/julien/Software/Others/OpenStudio3/src/nano/nano_signal_slot.hpp:40:41: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw] 40 | Observer::insert(Delegate::template bind(instance), this); | ^ /Users/julien/Software/Others/OpenStudio3/src/nano/nano_signal_slot.hpp:74:41: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw] 74 | Observer::remove(Delegate::template bind(instance), this); | ^ 2 errors generated. ```
…e not specifying types.
```
/Users/julien/.conan2/p/b/boost1b0853b234640/p/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'lock_access_mode' [-Wenum-constexpr-conversion]
73 | typedef AUX_WRAPPER_INST( BOOST_MPL_AUX_STATIC_CAST(AUX_WRAPPER_VALUE_TYPE, (value - 1)) ) prior;
| ^
/Users/julien/.conan2/p/b/boost1b0853b234640/p/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
24 | # define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
```
```
In file included from /Users/julien/.conan2/p/b/boost1b0853b234640/p/include/boost/numeric/ublas/traits.hpp:21:
/Users/julien/.conan2/p/b/boost1b0853b234640/p/include/boost/numeric/ublas/detail/iterator.hpp:204:21: error: 'iterator<boost::numeric::ublas::dense_random_access_iterator_tag, double>' is deprecated [-Werror,-Wdeprecated-declarations]
204 | public std::iterator<IC, T> {
| ^
/Users/julien/.conan2/p/b/boost1b0853b234640/p/include/boost/numeric/ublas/vector_expression.hpp:1333:20: note: in instantiation of template class 'boost::numeric::ublas::random_access_iterator_base<boost::numeric::ublas::dense_random_access_iterator_tag, boost::numeric::ublas::vector_binary_scalar2<boost::numeric::ublas::vector<double>, const double, boost::numeric::ublas::scalar_multiplies<double, double>>::const_iterator, double>' requested here
1333 | public iterator_base_traits<typename E1::const_iterator::iterator_category>::template
```
jmarrec
commented
Apr 25, 2025
Comment on lines
+1
to
+14
| #ifndef CPPRESTSDK_CHAR_TRAITS_WORKAROUND | ||
| #define CPPRESTSDK_CHAR_TRAITS_WORKAROUND | ||
|
|
||
| // https://github.com/microsoft/cpprestsdk/issues/1812 | ||
|
|
||
| #include <cstdint> | ||
| #include <cstring> | ||
| #include <string> | ||
|
|
||
| namespace std { | ||
| template <> | ||
| struct char_traits<uint8_t> | ||
| { | ||
| using char_type = uint8_t; |
Collaborator
Author
There was a problem hiding this comment.
I'm reimplementing std::char_traits<uint8_t>...
Comment on lines
+24
to
28
| #if __APPLE__ | ||
| # include "../../dependencies/cpprestsdk_char_traits_workaround.hpp" | ||
| #endif | ||
| #define _TURN_OFF_PLATFORM_STRING // cpprestsdk has an ugly macro U() that makes fmt break... | ||
| #include <cpprest/http_listener.h> |
Collaborator
Author
There was a problem hiding this comment.
And I include it where needed..
Comment on lines
+17
to
+19
| #if __APPLE__ | ||
| # include "../../../dependencies/cpprestsdk_char_traits_workaround.hpp" | ||
| #endif |
| template <typename L> | ||
| void disconnect(L* instance) { | ||
| Observer::remove(Delegate::template bind(instance), this); | ||
| Observer::remove(Delegate::bind(instance), this); |
Collaborator
Author
There was a problem hiding this comment.
Clang has a new warning -Wmissing-template-arg-list-after-template-kw that requires a template argument list after using the template keyword.
See llvm/llvm-project#94194 for the upstream clang changes.
I'm using CTAD.
CMakeLists.txt
Outdated
Comment on lines
547
to
548
| # TODO: workaround for #5398, remove when updating boost | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-enum-constexpr-conversion -Wno-deprecated-declarations") |
Collaborator
Author
There was a problem hiding this comment.
New flags for boost 1.79.0
Collaborator
|
CI Results for 2956fd9:
|
kbenne
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.