Skip to content

Conversation

@joseph-robertson
Copy link
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Mar 20, 2025
@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Mar 20, 2025
… centos7 that I just finished building myself
@jmarrec jmarrec marked this pull request as ready for review March 21, 2025 14:06
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 21, 2025

@joseph-robertson I added the mac SHAs (I kicked the E+ workflow back online this morning and it worked this time) + windows i386 and centos7 that I just finished building myself.

Assuming CI is still green, let's merge this without wait

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 21, 2025

I don't know what 22.04 is tripping on, but I doubt it's anything that can't be fixed via a wipe of the build dir. I didn't change the E+ package for it, so it's probably a roundtrip of building this PR and others.

I'm going to ignore, given how unreliable CI is anyways

@jmarrec jmarrec merged commit 128cd13 into develop Mar 21, 2025
4 of 6 checks passed
@jmarrec jmarrec deleted the v25.1.0-RC1 branch March 21, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants