Skip to content

Fix #5307 - DefrostEnergyInputRatioModifierFunctionofTemperatureCurve is orphaned when AirConditionerVariableRefrigerantFlow is removed #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmarrec merged 2 commits into from
Mar 20, 2025
Merged

Fix #5307 - DefrostEnergyInputRatioModifierFunctionofTemperatureCurve is orphaned when AirConditionerVariableRefrigerantFlow is removed #5374

jmarrec merged 2 commits into from
Mar 20, 2025

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 20, 2025 •
edited
Loading

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Model API methods are tested (in src/model/test)

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

jmarrec added 2 commits March 20, 2025 12:43
@jmarrec
Add a test for #5307
1d14a7e 
```
715: [ RUN      ] ModelFixture.AirConditionerVariableRefrigerantFlow_RemoveCurves
715: /Users/julien/Software/Others/OpenStudio/src/model/test/AirConditionerVariableRefrigerantFlow_GTest.cpp:401: Failure
715: Expected equality of these values:
715:   0
715:   model.getModelObjects<Curve>().size()
715:     Which is: 1
715:
715: /Users/julien/Software/Others/OpenStudio/src/model/test/AirConditionerVariableRefrigerantFlow_GTest.cpp:412: Failure
715: Expected equality of these values:
715:   0
715:   model.getModelObjects<Curve>().size()
715:     Which is: 1
```
@jmarrec
Fix #5307 - Add missing curve in AirCondVRF::children method
68a592e
@jmarrec jmarrec added severity - Minor Bug component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Mar 20, 2025
@jmarrec jmarrec self-assigned this Mar 20, 2025
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 20, 2025 •
edited
Loading

CI Results for 68a592e:

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 20, 2025

@joseph-robertson If you can spare a minute to review this quick PR that'd be great. I'm quite positive this can drop in right now.

joseph-robertson
joseph-robertson approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward -- just missing a curve in the children method.

@jmarrec jmarrec merged commit 0f14dd3 into develop Mar 20, 2025
5 of 6 checks passed
@jmarrec jmarrec deleted the 5307-AirCondVRF-CurveRemove branch March 20, 2025 16:44
@jmarrec jmarrec mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@jmarrec jmarrec

Labels

component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Minor Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deleting objects with OS:Table:Lookup does not delete the tables

4 participants

@jmarrec @ci-commercialbuildings @joseph-robertson