Fix #5309 - ThreeJSForwardTranslator adds unnecessary RenderingColor objects for AirLoopHVAC #5373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` 2652: /Users/julien/Software/Others/OpenStudio/src/model/test/ThreeJSForwardTranslator_GTest.cpp:427: Failure 2652: Expected equality of these values: 2652: 1 2652: m.getConcreteModelObjects<RenderingColor>().size() 2652: Which is: 2 ```
… it exists before adding
jmarrec
commented
Mar 20, 2025
| EXPECT_TRUE(checkIfMaterialExist(materials, "AirWall")); | ||
| } | ||
|
|
||
| TEST_F(ModelFixture, ThreeJSForwardTranslator_AirLoopHVAC_RenderingColors) { |
Collaborator
Author
There was a problem hiding this comment.
New test that creates an AirLoopHVAC, call modelToThreeJS twice and ensure we don't end up with 2 RenderingColors
Comment on lines
+68
to
+72
| std::string name = getObjectThreeMaterialName(construction); | ||
| boost::optional<RenderingColor> color = construction.renderingColor(); | ||
| if (!color) { | ||
| color = RenderingColor(model); | ||
| color->setName(name); |
Collaborator
Author
There was a problem hiding this comment.
For all objects, name the rendering color!
Comment on lines
138
to
147
| for (auto& airLoopHVAC : model.getConcreteModelObjects<AirLoopHVAC>()) { | ||
| std::string name = getObjectThreeMaterialName(airLoopHVAC); | ||
| boost::optional<RenderingColor> color = RenderingColor(model); | ||
| // AirLoopHVAC does not have a renderingColor method | ||
| boost::optional<RenderingColor> color = model.getConcreteModelObjectByName<RenderingColor>(name); | ||
| if (!color) { | ||
| color = RenderingColor(model); | ||
| color->setName(name); | ||
| } | ||
| addThreeMaterial(materials, materialMap, | ||
| makeThreeMaterial(name, toThreeColor(color->renderingRedValue(), color->renderingBlueValue(), color->renderingGreenValue()), 1, |
Collaborator
Author
There was a problem hiding this comment.
For AirLoopHVAC, where we don't have a renderingColor method, we check if the model contains the aptly-named one first before creating.
If we create it, we name it.
all good!
Collaborator
|
CI Results for 2c8b19f:
|
joseph-robertson
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.