Fix #5343 - Design Range Temperature for OS:CoolingTower:SingleSpeed is not being converted into EnergyPlus #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not being converted into EnergyPlus
jmarrec
commented
Jan 14, 2025
| Test/Construction_GTest.cpp | ||
| Test/ConstructionWithInternalSource_GTest.cpp | ||
| Test/ControllerOutdoorAir_GTest.cpp | ||
| Test/CoolingTowerSingleSpeed_GTest.cpp |
Collaborator
Author
There was a problem hiding this comment.
There was no FT test for the object, so I started by adding one
Comment on lines
+62
to
+64
| EXPECT_TRUE(ct.setDesignApproachTemperature(3.89)); | ||
| // ct.autosizeDesignRangeTemperature(); | ||
| EXPECT_TRUE(ct.setDesignRangeTemperature(5.55)); |
Comment on lines
+114
to
+115
| EXPECT_EQ(3.89, idfObject.getDouble(CoolingTower_SingleSpeedFields::DesignApproachTemperature).get()); | ||
| EXPECT_EQ(5.55, idfObject.getDouble(CoolingTower_SingleSpeedFields::DesignRangeTemperature).get()); |
Collaborator
Author
There was a problem hiding this comment.
$ ninja && Products/openstudio_energyplus_tests -- --gtest_filter=*ForwardTranslator_CoolingTowerSingleSpeed*
[100%][2/2] Linking CXX executable Products/openstudio_energyplus_tests
Running main() from gmock_main.cc
Note: Google Test filter = *ForwardTranslator_CoolingTowerSingleSpeed*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed
/media/DataExt4/Software/Others/OpenStudio3/src/energyplus/Test/CoolingTowerSingleSpeed_GTest.cpp:115: Failure
Expected equality of these values:
5.55
idfObject.getDouble(CoolingTower_SingleSpeedFields::DesignRangeTemperature).get()
Which is: 3.89
[ FAILED ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed (217 ms)
[----------] 1 test from EnergyPlusFixture (217 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (218 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed
| if (modelObject.isDesignRangeTemperatureAutosized()) { | ||
| idfObject.setString(openstudio::CoolingTower_SingleSpeedFields::DesignRangeTemperature, "Autosize"); | ||
| } else if ((d = modelObject.designApproachTemperature())) { | ||
| } else if ((d = modelObject.designRangeTemperature())) { |
Collaborator
Author
There was a problem hiding this comment.
This was a copy paste error
Collaborator
|
CI Results for d438c3b:
|
Collaborator
|
also fixes (duplicate issue): #5338 |
Collaborator
Author
|
Thanks @eringold I just took the issue list from the top down and didn't get there! |
joseph-robertson
approved these changes
Jan 14, 2025
Collaborator
joseph-robertson
left a comment
There was a problem hiding this comment.
Probably a copy-paste mistake of modelObject.designApproachTemperature()? New FT test 👍
Collaborator
Author
|
Yeah, defiitely a copy paste issue. Strange that it took us (and I mean the entire community) 8 years to notice it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test): No Changesrc/energyplus/Test): Added a new unit test filewater_economizer.osmandcoolingtowers.osmsrc/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.