Skip to content

Copyright cleanup #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmarrec merged 4 commits into from
Mar 11, 2025
Merged

Copyright cleanup #5344

jmarrec merged 4 commits into from
Mar 11, 2025

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jan 14, 2025

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Jan 14, 2025
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Jan 14, 2025
jmarrec
jmarrec commented Jan 14, 2025
View reviewed changes
developer/ruby/SubProjectClassGenerators/FileHeader.rb
Comment on lines +6 to +7
fileHeader << "* OpenStudio(R), Copyright (c) Alliance for Sustainable Energy, LLC.\n"
fileHeader << "* See also https://openstudio.net/license\n"
Copy link
Collaborator Author

@jmarrec jmarrec Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this was outdated when I tried to use GenerateClass.rb to create a missing FT test for CoolingTowerSingleSpeed, so I decided to clean everything up

src/alfalfa/AlfalfaActuator.hpp
Comment on lines +1 to +4
/***********************************************************************************************************************
* OpenStudio(R), Copyright (c) Alliance for Sustainable Energy, LLC.
* See also https://openstudio.net/license
***********************************************************************************************************************/
Copy link
Collaborator Author

@jmarrec jmarrec Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used ruby developer/ruby/ApplyCopyright.rb which is responsible for most of these changes

src/cli/MeasureUpdateCommand.cpp
Comment on lines -6 to -9
/***********************************************************************************************************************
* OpenStudio(R), Copyright (c) 2008-2023, Alliance for Sustainable Energy, LLC, and other contributors. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
Copy link
Collaborator Author

@jmarrec jmarrec Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and did some manual cleaning up for some files which had the current short license text AND the former one.

@jmarrec jmarrec force-pushed the copyright_cleanup branch from 7b38a3b to cf0f47e Compare March 11, 2025 09:02
@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 11, 2025

https://openstudio.net/license is up to date now.

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 11, 2025 •
edited
Loading

CI Results for cf0f47e:

@jmarrec jmarrec merged commit 3e5a898 into develop Mar 11, 2025
3 of 6 checks passed
@jmarrec jmarrec deleted the copyright_cleanup branch March 11, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidGoldwasser DavidGoldwasser Awaiting requested review from DavidGoldwasser

Assignees

@jmarrec jmarrec

Labels

Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmarrec @ci-commercialbuildings