Skip to content

Conversation

@wenyikuang
Copy link
Contributor

Thanks to Julien's patch of radiance.

Pull request overview

This radiance can make the centos build of openstudio way more easiser.
It can pull down the shebanged version of radiance from s3 and use it directly. Not need shebang it again in building env.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@wenyikuang wenyikuang added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. dependencies Pull requests that update a dependency file labels Dec 18, 2024
@wenyikuang wenyikuang requested a review from jmarrec December 18, 2024 17:42
@wenyikuang wenyikuang self-assigned this Dec 18, 2024
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Dec 18, 2024

Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks!

@jmarrec jmarrec merged commit f472655 into develop Dec 18, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Openstudio 3.6.0 rpm cannot be installed properly under CentOS 7.

4 participants