Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Nov 6, 2024

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Developer Issue component - C# Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Nov 6, 2024
@jmarrec jmarrec self-assigned this Nov 6, 2024
@TShapinsky
Copy link
Member

@jmarrec I have the fix for the build failing when building the test. Do you want me to push it here?

@jmarrec
Copy link
Collaborator Author

jmarrec commented Nov 7, 2024

@TShapinsky In the interest of efficiency, please always assume that is fine if I'm not on slack and it's nighttime in France and it's a quick fix (if you touch 1000s of lines, a PR pointing to the PR like you did is better). I can always revert back or adjust if not.

In this specific case, a code suggestion (since I did touch these lines) would have worked too.

@jmarrec jmarrec marked this pull request as ready for review November 7, 2024 13:22
@jmarrec jmarrec merged commit b5a6c58 into develop Nov 7, 2024
@jmarrec jmarrec deleted the CSharp branch November 7, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - C# Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken C# bindings workflow

4 participants