Fix #5274 - workflow should not remove contents from zip because of size limit #5275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joseph-robertson
left a comment
There was a problem hiding this comment.
I don't believe I'm familiar with this utility, so it's hard for me to say whether this approach looks good. Does zipDirectory get executed for every workflow run? Should we, at a minimum, set label for this PR to "Pull Request - Ready for CI" so we can check builds are successful?
Collaborator
Author
|
There should be a |
794c0ce to
77d1ef3
Compare
Contributor
|
Rebased on develop let's run CI and see. |
jmarrec
approved these changes
Oct 29, 2024
Comment on lines
-249
to
-259
| auto directorySize = [](const openstudio::path& dirPath) { | ||
| uintmax_t dirSize = 0; | ||
| for (const auto& dirEnt : fs::recursive_directory_iterator{dirPath}) { | ||
| const auto& dirEntryPath = dirEnt.path(); | ||
| if (fs::is_regular_file(dirEntryPath)) { | ||
| dirSize += fs::file_size(dirEntryPath); | ||
| } | ||
| } | ||
| return dirSize; | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Lambda is now unused, so delete it too
Collaborator
|
CI Results for d79e5f7:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
We no longer want to limit file sizes that go into datapoint zip generated when a workflow is run.
Pull Request Author
@DavidGoldwasser
Labels:
Pull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.