Skip to content

GroundHeatExchangerVertical_Impl::addToNode sets plant loop fluid type to Water #5458

@joseph-robertson

Description

@joseph-robertson

Issue overview

The addToNode method for GroundHeatExchangerVertical (re)sets its plant loop's fluid type to "Water". This seems unexpected/incorrect. For comparison, the same method for GroundHeatExchangerHorizontalTrench does not do this.

Current Behavior

The plant loop for which you are adding the GHE Vertical object as a supply component has its fluid type set to Water.

For the same addToNode method, both BoilerHotWater and BoilerSteam sets their fluid type to Water and Steam, respectively. While this seems more appropriate, perhaps this behavior should be removed as well?

Expected Behavior

The plant loop should not have its fluid type changed.

Steps to Reproduce

  1. Create a plant loop with Fluid Type = "PropyleneGlycol" and Glycol Concentration = "20".
  2. Create a ground heat exchanger vertical.
  3. Call plant_loop.addSupplyBranchForComponent(ground_heat_exch_vert).
  4. See that now Fluid Type = "Water".

Possible Solution

Delete the line(s) that reset the fluid type to Water. Follow GroundHeatExchangerHorizontalTrench's addToNode method as a guide.

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions