-
Notifications
You must be signed in to change notification settings - Fork 222
Description
Issue overview
The addToNode method for GroundHeatExchangerVertical (re)sets its plant loop's fluid type to "Water". This seems unexpected/incorrect. For comparison, the same method for GroundHeatExchangerHorizontalTrench does not do this.
Current Behavior
The plant loop for which you are adding the GHE Vertical object as a supply component has its fluid type set to Water.
For the same addToNode method, both BoilerHotWater and BoilerSteam sets their fluid type to Water and Steam, respectively. While this seems more appropriate, perhaps this behavior should be removed as well?
Expected Behavior
The plant loop should not have its fluid type changed.
Steps to Reproduce
- Create a plant loop with Fluid Type = "PropyleneGlycol" and Glycol Concentration = "20".
- Create a ground heat exchanger vertical.
- Call
plant_loop.addSupplyBranchForComponent(ground_heat_exch_vert). - See that now Fluid Type = "Water".
Possible Solution
Delete the line(s) that reset the fluid type to Water. Follow GroundHeatExchangerHorizontalTrench's addToNode method as a guide.
Details
Environment
Some additional details about your environment for this issue (if relevant):
- Platform (Operating system, version):
- Version of OpenStudio (if using an intermediate build, include SHA):