Pull request overview

• Fixes Availability Manager List Name for AirLoopHVAC:OutdoorAirSystem not working #8814
• When the AirLoopHVAC:OutdoorAirSystem was implemented, it had an input field for an availability manager. While it read that in and made sure that availability manager existed in the idf, it never actually did anything else with that information or even assign it to the local data structure. There was nothing in place in the code to support using that information had it been assigned. The IORef had a statement that basically said it was ignored by EnergyPlus. Testing showed that it didn't matter what was entered for this field--the results were always the same. This work removed this input since it wasn't being used by the code. This involved changing the E+ code, creating a new unit test call from within an existing test, modifying both the transition and the expand objects programs, editing over 300 idf files to remove this line, and removing this text for this unused field from the IORef. No differences are noted in the test suite (because this field was never used anyway--confirming again that this field was not being used). Two input files show differences, but those differences are valid.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs