Fix #11283 - Evaporative Fluid Coolers cannot have an Autosized Design Entering Water Temperature #11284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
[ RUN ] EnergyPlusFixture.EvapFluidCooler_SingleSpeed_DesignEnteringWaterIsAutosized
/Users/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/EvaporativeFluidCoolers.unit.cc:406: Failure
Expected: EvapFluidCoolerSpecs::factory(*state, DataPlant::PlantEquipmentType::EvapFluidCooler_SingleSpd, "BIG EVAPORATIVEFLUIDCOOLER") doesn't throw an exception.
Actual: it throws EnergyPlus::FatalError with description "Errors found in getting evaporative fluid cooler input.".
/Users/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/Fixtures/EnergyPlusFixture.cc:219: Failure
Expected equality of these values:
expected_string
Which is: ""
stream_str
Which is: " ** Severe ** EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", invalid data for \"Design Entering Water Temperature\", entered value <= 0.0, but must be >0 for Performance Input Method = \"USERSPECIFIEDDESIGNCAPACITY\".\n ** Severe ** EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", Design Entering Water Temperature must be greater than Design Entering Air Wet-bulb Temperature.\n ** Fatal ** Errors found in getting evaporative fluid cooler input.\n ...Summary of Errors that led to program termination:\n ..... Reference severe error count=2\n ..... Last severe error=EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", Design Entering Water Temperature must be greater than Design Entering Air Wet-bulb Temperature.\n"
With diff:
@@ -1,1 +1,6 @@
-""
+ ** Severe ** EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", invalid data for \"Design Entering Water Temperature\", entered value <= 0.0, but must be >0 for Performance Input Method = \"USERSPECIFIEDDESIGNCAPACITY\".
+ ** Severe ** EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", Design Entering Water Temperature must be greater than Design Entering Air Wet-bulb Temperature.
+ ** Fatal ** Errors found in getting evaporative fluid cooler input.
+ ...Summary of Errors that led to program termination:
+ ..... Reference severe error count=2
+ ..... Last severe error=EvaporativeFluidCooler:SingleSpeed = \"BIG EVAPORATIVEFLUIDCOOLER\", Design Entering Water Temperature must be greater than Design Entering Air Wet-bulb Temperature.\n
```
…d work ** Severe ** EvaporativeFluidCooler:TwoSpeed = "BIG EVAPORATIVEFLUIDCOOLER", invalid data for "Low Speed User Specified Design Capacity", entered value <= 0.0, but must be > 0 for Performance Input Method = "USERSPECIFIEDDESIGNCAPACITY".
Program Version,EnergyPlus, Version 25.2.0-8709e19061, YMD=2025.10.22 23:05, ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - "-1" - Expected number greater than 0.000000 ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against child schema #0. ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Value type "number" for input "-1" not permitted by 'type' constraint. ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - "-1" - Failed to match against any enum values. ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against child schema #1. ** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against any schemas allowed by anyOf constraint.
jmarrec
commented
Oct 22, 2025
Comment on lines
-455
to
-464
| if (thisEFC.DesignEnteringWaterTemp <= 0.0) { | ||
| ShowSevereError(state, | ||
| format("{} = \"{}\", invalid data for \"{}\", entered value <= 0.0, but must be >0 for {} = \"{}\".", | ||
| state.dataIPShortCut->cCurrentModuleObject, | ||
| AlphArray(1), | ||
| state.dataIPShortCut->cNumericFieldNames(9), | ||
| state.dataIPShortCut->cAlphaFieldNames(4), | ||
| AlphArray(4))); | ||
| ErrorsFound = true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is useless. The Schema validates with minimum already
Program Version,EnergyPlus, Version 25.2.0-8709e19061, YMD=2025.10.22 23:05,
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - "-1" - Expected number greater than 0.000000
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against child schema #0.
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Value type "number" for input "-1" not permitted by 'type' constraint.
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - "-1" - Failed to match against any enum values.
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against child schema #1.
** Severe ** <root>[EvaporativeFluidCooler:SingleSpeed][Big EvaporativeFluidCooler][design_entering_water_temperature] - Failed to validate against any schemas allowed by anyOf constraint.
Comment on lines
+479
to
+488
| if (thisEFC.DesignEnteringWaterTemp != DataSizing::AutoSize) { | ||
| if (thisEFC.DesignEnteringWaterTemp <= thisEFC.DesignEnteringAirWetBulbTemp) { | ||
| ShowSevereError(state, | ||
| format("{} = \"{}\", {} must be greater than {}.", | ||
| state.dataIPShortCut->cCurrentModuleObject, | ||
| AlphArray(1), | ||
| state.dataIPShortCut->cNumericFieldNames(9), | ||
| state.dataIPShortCut->cNumericFieldNames(11))); | ||
| ErrorsFound = true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
In Get Input, we only check this if the DesignEnteringWaterTemp isn't autosized.
We'll check again in Size
Comment on lines
+871
to
+873
| if (thisEFC.LowSpeedUserSpecifiedDesignCapacity == Constant::AutoCalculate) { | ||
| thisEFC.LowSpeedUserSpecifiedDesignCapacity = thisEFC.HighSpeedUserSpecifiedDesignCapacity * NumArray(18); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
For the TwoSpeed one, before throwing because LowSpeedUserSpecifiedDesignCapacity is < 0, actually calculate it with NumArray(18) which was completely unused and which is the "Low Speed User Specified Design Capacity Sizing Factor"
Contributor
There was a problem hiding this comment.
Seems reasonable, and high speed capacity cannot be autosized and this field has a default.
N16, \field High Speed User Specified Design Capacity
\type real
\units W
\minimum> 0.0
\note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
\note for other Performance Input Methods, this field is ignored.
N17, \field Low Speed User Specified Design Capacity
\type real
\units W
\minimum> 0.0
\autocalculatable
\note Only used for Performance Input Method = UserSpecifiedDesignCapacity;
\note for other Performance Input Methods, this field is ignored.
N18, \field Low Speed User Specified Design Capacity Sizing Factor
\type real
\default 0.5
\note This field is only used if the previous field is set to autocalculate
Contributor
Author
There was a problem hiding this comment.
I'm realizing that N17 should have \default autocalculate to be pedantic about IDD correctness
Comment on lines
+1365
to
+1366
| if (this->DesignEnteringWaterTempWasAutoSized && this->PerformanceInputMethod_Num == PIM::UserSpecifiedDesignCapacity) { | ||
| if (PltSizCondNum > 0) { |
Contributor
Author
There was a problem hiding this comment.
If we're in UserSpecifiedDesignCapacity, and DesignEnteringWaterTempWasAutoSized
Comment on lines
1365
to
1383
| this->DesignEnteringWaterTemp = | ||
| state.dataSize->PlantSizData(PltSizCondNum).ExitTemp + state.dataSize->PlantSizData(PltSizCondNum).DeltaT; | ||
|
|
||
| if (this->DesignEnteringWaterTemp <= this->DesignEnteringAirWetBulbTemp) { | ||
| ShowSevereError( | ||
| state, format("Error when autosizing the Design Entering Water Temperature for Evaporative Fluid Cooler = {}.", this->Name)); | ||
| ShowContinueError( | ||
| state, | ||
| format("Design Entering Water Temperature ({:.2R} C) must be greater than design entering air wet-bulb temperature " | ||
| "({:.2R} C).", | ||
| this->DesignEnteringWaterTemp, | ||
| this->DesignEnteringAirWetBulbTemp)); | ||
| ShowContinueError( | ||
| state, | ||
| "Check the Sizing:Plant object and the Design Entering Air Wet-bulb Temp input field for the Evaporative Fluid Cooler."); | ||
| ShowFatalError(state, "Review and revise design input values as appropriate."); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We assign to the Sizing:Plant values, and we check that the Temps are matching because we skipped that in Get Input
Comment on lines
+465
to
+475
|
|
||
| sizingPlant.ExitTemp = 30.0; | ||
| expected_ewt = sizingPlant.ExitTemp + sizingPlant.DeltaT; | ||
| EXPECT_EQ(40.0, expected_ewt); | ||
|
|
||
| EXPECT_NO_THROW(ptr->SizeEvapFluidCooler(*state)); | ||
| compare_err_stream(""); | ||
| EXPECT_EQ(expected_ewt, ptr->DesignEnteringWaterTemp); | ||
|
|
||
| EXPECT_TRUE(compare_eio_stream_substring("Component Sizing Information, EvaporativeFluidCooler:SingleSpeed, BIG EVAPORATIVEFLUIDCOOLER, " | ||
| "Design Entering Water Temperature [C], 40.00000")); |
Contributor
Author
There was a problem hiding this comment.
Test valid case: should report to EIO
| "Design Entering Water Temperature [C], 40.00000")); | ||
| } | ||
|
|
||
| TEST_F(EnergyPlusFixture, EvapFluidCooler_TwoSpeed_DesignEnteringWaterIsAutosized) |
Contributor
Author
There was a problem hiding this comment.
Same test but for the TwoSpeed
| "Design Entering Water Temperature [C], 40.00000")); | ||
| } | ||
|
|
||
| TEST_F(EnergyPlusFixture, EvapFluidCooler_TwoSpeed_UserSpecifiedDesignCapacity_LowSpeed_CanAutocalculate) |
Contributor
Author
There was a problem hiding this comment.
And a test for the LowSpeed autocalculate
Comment on lines
+639
to
+640
| EXPECT_NO_THROW(EvapFluidCoolerSpecs::factory(*state, DataPlant::PlantEquipmentType::EvapFluidCooler_TwoSpd, "BIG EVAPORATIVEFLUIDCOOLER")); | ||
| compare_err_stream(""); |
Contributor
Author
There was a problem hiding this comment.
Before this
** Severe ** EvaporativeFluidCooler:TwoSpeed = "BIG EVAPORATIVEFLUIDCOOLER", invalid data for "Low Speed User Specified Design Capacity", entered value <= 0.0, but must be > 0 for Performance Input Method = "USERSPECIFIEDDESIGNCAPACITY".
Comment on lines
+645
to
+646
| EXPECT_EQ(87921.0, ptr->HighSpeedUserSpecifiedDesignCapacity); | ||
| EXPECT_EQ(87921.0 * 0.25, ptr->LowSpeedUserSpecifiedDesignCapacity); |
Contributor
Author
There was a problem hiding this comment.
Test that the calculated LowSpeed is ok
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
… and PltSizCondNum is given to avoid diffs in Reporting Range
19 tasks
mitchute
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Low Speed User Specified Design Capacity(using theLow Speed User Specified Design Capacity Sizing Factor)Description of the purpose of this PR
Pull Request Author
Reviewer