Skip to content

Conversation

@JasonGlazer
Copy link
Contributor

@JasonGlazer JasonGlazer commented Sep 18, 2025

Pull request overview

Description of the purpose of this PR

EP-Launch 2.16 that was part of the EnergyPlus 25.1 distribution showed a blank interface on the "utility" tab and this fixes the issue.

Fixes EP-Launch Utility tab so that it can run AppGPostProcess again

Fixes EP-Launch Utility tab so it no longer includes EP-Compare

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@JasonGlazer JasonGlazer self-assigned this Sep 18, 2025
@JasonGlazer JasonGlazer added the Defect Includes code to repair a defect in EnergyPlus label Sep 18, 2025
@JasonGlazer JasonGlazer requested a review from mjwitte September 18, 2025 11:22
@JasonGlazer JasonGlazer marked this pull request as draft September 18, 2025 11:31
@JasonGlazer JasonGlazer changed the title EP-Launch - Fix frame ordering so utility tab is not blank EP-Launch - Fix blank utility tab and running AppGPostProcessor Sep 18, 2025
@JasonGlazer JasonGlazer marked this pull request as ready for review September 18, 2025 13:30
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem just fine.

utilProg(7).outExt5 = ""
utilProg(7).outExt6 = ""
utilProg(7).applicationFile = "PostProcess\AppGPostProcess\appgpostprocess.exe"
utilProg(7).applicationFile = "PostProcess\AppGPostProcess.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Myoldmopar
Copy link
Member

I'll just trust you on the binaries. Thanks @JasonGlazer

@Myoldmopar Myoldmopar merged commit b4a31e8 into develop Sep 18, 2025
8 checks passed
@Myoldmopar Myoldmopar deleted the Fix-111175-EPLaunchUtilTabBlank branch September 18, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EP-Launch with 25.1 release shows blank "utility" tab. AppGPostProcess does not run from EP-Launch Utilities tab

3 participants