Skip to content

Conversation

@jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Aug 25, 2025

Pull request overview

I don't think it warrants making this an actual defect ticket and writing complicated unit tests, so I'm just fixing it quickly.

I checked SetupOutputVariables.csv (parse_output_variables.py) and didn't find other "Flow Rate" variables with StoreType::Sum instead of average

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec requested a review from Myoldmopar August 25, 2025 14:25
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Aug 25, 2025
@jmarrec jmarrec self-assigned this Aug 25, 2025
Copy link
Contributor

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit ae5b8db

Regression Summary
  • Audit: 1
  • RDD: 1
  • ESO Big Diffs: 1

Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for sure. I'm almost tempted to say we should be able to detect the sum/average based on the specified unit type, but whether we can or not -- we aren't doing it here. :)

@Myoldmopar
Copy link
Member

Thanks @jmarrec, merging.

@Myoldmopar Myoldmopar merged commit 9531f23 into develop Sep 18, 2025
10 checks passed
@Myoldmopar Myoldmopar deleted the 11157_OAStoreType branch September 18, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect StoreType for Zone Combined Outdoor Air Volume Flow Rate output variables

6 participants