Pull request overview

• Fixes Incorrect Unit Conversion for Airflow per Total Capacity in Zone Component Load Summary (IP-Units) #11143

Description of the purpose of this PR

In the output report tables, the values for air flow per power were not being converted correctly. There was an additional "per area" term that was included so that the conversion was air flow per area per power rather than the correct air flow per power. This was corrected and any output table that includes this value will change (correctly reported now whereas before the value in IP units was incorrect). Also, while testing this fix, it was noticed that the unit test for these output reports had a bug in it where the conversion factors were not being set up during the unit test. As a result, all of the conversion factors were coming back as 1.0 and the unit tests weren't actually doing anything. So, rather than a new unit test, this work includes a correction to those existing unit tests as well as corrections that mirror the actual fix to the issue raised in the defect.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs