You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new Equipment Summary subtable with fan power fractions for every fan. Making this a separate PR to make sure there are no side effects from a series of calls to fan->simulate during FillRemainingPredefinedEntries. It should be safe here, but need to confirm that there are no diffs other than the new table output.
Removed unused ERV object (and fans and HX) from testfile US+SF+CZ4A+hp+crawlspace+IECC_2006_VRF. This introduces err, rdd, mtd, bnd, etc. diffs for this file, eliminating several sets of error messages with no change in results.
Pull Request Author
Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If changes fix a defect, the fix should be demonstrated in plots and descriptions
If any defect files are updated to a more recent version, upload new versions here or on DevSupport
If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
If structural output changes, add to output rules file and add OutputChange label
If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
Reviewer
Perform a Code Review on GitHub
If branch is behind develop, merge develop and build locally to check for side effects of the merge
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified
Check that performance is not impacted (CI Linux results include performance check)
Run Unit Test(s) locally
Check any new function arguments for performance impacts
Verify IDF naming conventions and styles, memos and notes and defaults
If new idf included, locally check the err file and other outputs
mjwitte
added
NewFeature
Includes code to add a new feature to EnergyPlus
OutputChange
Code changes output in such a way that it cannot be merged after IO freeze
labels
Aug 15, 2025
@rraustad There are eio diffs in US+SF+CZ4A+hp+crawlspace+IECC_2006_VRF-ddays,
because the zone ERV fans are never called before this report fires, because the ZoneHVAC:EnergyRecoveryVentilator object isn't in the zone equipment list.
** Severe ** Orphaned ZoneHVAC object found. This was object never referenced in the input, and was not used.
** ~~~ ** -- Object type: ZoneHVAC:EnergyRecoveryVentilator
** ~~~ ** -- Object name: ERV_unit1
I'm going to clean that up (delete the ZoneHVAC:EnergyRecoveryVentilator and associated fans) here.
Code looks good, diffs shown are reasonable for code and idf changes. The table looks good and appears to reflect the fan inputs. Doc build failure is not related. This can merge when ready.
Fan:SystemModel,
TU1 VRF Supply Fan, !- Name
0.69748, !- Electric Power Minimum Flow Rate Fraction
Fan:SystemModel,
TU1 VRF Supply Fan, !- Name
0.19748, !- Electric Power Minimum Flow Rate Fraction
NewFeatureIncludes code to add a new feature to EnergyPlusOutputChangeCode changes output in such a way that it cannot be merged after IO freezeRPD
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
fan->simulateduringFillRemainingPredefinedEntries. It should be safe here, but need to confirm that there are no diffs other than the new table output.Pull Request Author
Reviewer