Extend Equipment and System Summary Tables - Air Heat Recovery, Air Terminals, and Fans #11138

mjwitte · 2025-07-30T14:57:07Z

Pull request overview

Extends the Equipment Summary - Air Heat Recovery table output to support RPD. Adds the following new columns:
- Heat Recovery Active ("WhenFansOn", "Scheduled", "WhenOutsideEconomizerLimits", "WhenMinimumOutdoorAir")
- Zone HVAC Name
- Airloop Name
- OA System Name
- OA Controller Name
Extends the Equipment Summary - Air Terminals table output. Add the following new columns:
- PIU Heating Control Type ("Modulated", "Staged")
- PIU Fan Control Type ("ConstantSpeed", "VariableSpeed")
Extends the Equipment Summary - Fans table output. Add the following new columns:
- Speed Control Method ("Discrete", "Continuous")
- Number of Speeds ("N/A" for Continuous speed control method)
Adds new System Summary Report, Fan Operation subtable with the following columns:
- Occupied Time [hr]
- Occupied Continuous Fan [hr]
- Occupied Cycling Fan [hr]
- Occupied Fan Off [hr]
- Unoccupied Time [hr]
- Unoccupied Continuous Fan [hr]
- Unoccupied Cycling Fan [hr]
- Unoccupied Fan Off [hr]

Pull Request Author

Reviewer

github-actions · 2025-07-30T23:04:07Z

⚠️ Regressions detected on macos-14 for commit `ce97f40`

Regression Summary

Audit: 796
Table Big Diffs: 738

github-actions · 2025-07-31T00:12:01Z

⚠️ Regressions detected on macos-14 for commit `64adf5b`

Regression Summary

Audit: 796
Table Big Diffs: 738

github-actions · 2025-08-06T17:36:58Z

⚠️ Regressions detected on macos-14 for commit `77ace05`

Regression Summary

Audit: 796
Table Big Diffs: 738

mjwitte · 2025-08-07T18:51:37Z

@JasonGlazer Some examples of the new Air Heat Recovery Table columns.
ASHRAE901_HotelLarge_STD2019_Denver

DOAToUnitarySystem

OutdoorAirUnit

mjwitte · 2025-08-07T20:11:01Z

@JasonGlazer Some examples of the new PIU Air Terminal columns

PIUAuto - The PIU heating control type only applies with VariableSpeed fan. It's blank now for constant speed fan. Would you prefer "n/a"?

5ZoneAirCooledConvCoef_VSFan

github-actions · 2025-08-07T21:20:32Z

⚠️ Regressions detected on macos-14 for commit `c80f755`

Regression Summary

Audit: 796
Table Big Diffs: 738

mjwitte · 2025-08-08T15:44:30Z

@JasonGlazer Some example for the new Fans columns.
StripMallZoneEvapCooler.idf

Fans/FanCoilAutoSize_MultiSpeedFan

5ZoneAirCooledConvCoef_VSFan

For the PIU fans, Airloop Name is "N/A" - is that expected or a bug?

github-actions · 2025-08-08T16:58:28Z

⚠️ Regressions detected on macos-14 for commit `971aef8`

Regression Summary

Audit: 796
Table Big Diffs: 738

github-actions · 2025-08-11T17:27:29Z

⚠️ Regressions detected on macos-14 for commit `059c5f3`

Regression Summary

Audit: 796
Table Big Diffs: 738

mjwitte · 2025-08-11T21:20:49Z

A couple of samples of the new System Summary Report, Fan Operation subtable.
FurnaceWithDXSystem-ContFanOccupied-Annual

5ZoneAirCooledConvCoef_VSFan-Annual

github-actions · 2025-08-12T01:15:09Z

⚠️ Regressions detected on macos-14 for commit `04b25b2`

Regression Summary

Audit: 796
Table Big Diffs: 738

JasonGlazer · 2025-08-12T21:25:12Z

PIUAuto - The PIU heating control type only applies with VariableSpeed fan. It's blank now for constant speed fan. Would you prefer "n/a"?

Generally, I prefer "n/a" over a blank since it means that it wasn't just overlooked but actively reported.

JasonGlazer · 2025-08-12T21:26:10Z

For the PIU fans, Airloop Name is "N/A" - is that expected or a bug?

Probably a bug..

mjwitte · 2025-08-13T17:03:28Z

PIUAuto - The PIU heating control type only applies with VariableSpeed fan. It's blank now for constant speed fan. Would you prefer "n/a"?

Generally, I prefer "n/a" over a blank since it means that it wasn't just overlooked but actively reported.

Ok, "n/a" added, but the two PIU columns will be left blank for non-PIU terminal units.

mjwitte · 2025-08-13T17:12:50Z

Here's an example of the air terminals subtable.

mjwitte · 2025-08-13T19:23:06Z

For the PIU fans, Airloop Name is "N/A" - is that expected or a bug?

Probably a bug..

Fixed here.

github-actions · 2025-08-13T22:02:19Z

⚠️ Regressions detected on macos-14 for commit `9fcd85d`

Regression Summary

Audit: 796
Table Big Diffs: 738

rraustad · 2025-08-14T01:23:26Z

src/EnergyPlus/Fans.cc

-    airLoopNum = state.dataSize->CurSysNum;
+    if (state.dataSize->CurSysNum > 0) {
+        airLoopNum = state.dataSize->CurSysNum;
+    }


I don't understand why this is needed. For this->fan, why is checking for CurSysNum > 0 necessary? If this fan is in the air loop, OA sys, or DOAS, then airloopNum > 0, otherwise it's 0. So what did you find that required this check?

I don't understand why this is needed. For this->fan, why is checking for CurSysNum > 0 necessary? If this fan is in the air loop, OA sys, or DOAS, then airloopNum > 0, otherwise it's 0. So what did you find that required this check?

Because the fan is in the PIU terminal unit, it gets simulated as zone equipment, so CurSysNum is 0 here for the PIU fans. But the terminal unit is ultimately connected to an airloop, so the check here avoids stomping on the fan's airLoopNum which is now set by the PIU terminal unit init. Maybe I should add a comment here?

But the fan in the PIU will never see CurSysNum > 0, will it? Does it make sense for a zone equipment fan to know that information? The PIU unit knows what air loop it is attached to here (line 967). Maybe something similar to this for zone equiuipment?

int const AirLoopNum = state.dataZoneEquip->ZoneEquipConfig(thisPIU.CtrlZoneNum).InletNodeAirLoopNum(thisPIU.ctrlZoneInNodeIndex);

OK, I see your point with "is now set by the PIU terminal unit type" although I don't see where that happens. I didn't realize parent equipment set that variable but that does make sense. So your check here is valid.

rraustad · 2025-08-14T15:17:37Z

src/EnergyPlus/PoweredInductionUnits.cc

                thisPIU.AirLoopNum = state.dataZoneEquip->ZoneEquipConfig(thisPIU.CtrlZoneNum).InletNodeAirLoopNum(thisPIU.ctrlZoneInNodeIndex);
                state.dataDefineEquipment->AirDistUnit(thisPIU.ADUNum).AirLoopNum = thisPIU.AirLoopNum;
+                // Set the airloopnum for the PIU fan
+                state.dataFans->fans(thisPIU.Fan_Index)->airLoopNum = thisPIU.AirLoopNum;


Ahh, right here. That's what "is now set" means.

mjwitte · 2025-09-09T22:23:31Z

@JasonGlazer This new table only reports for airloop systems, not for zone systems such as fancoils. Is that adequate?

A couple of samples of the new System Summary Report, Fan Operation subtable. FurnaceWithDXSystem-ContFanOccupied-Annual

5ZoneAirCooledConvCoef_VSFan-Annual

github-actions · 2025-09-09T22:32:36Z

⚠️ Regressions detected on ubuntu-24.04 for commit `5049249`

Regression Summary

Audit: 799
Table Big Diffs: 740

github-actions · 2025-09-09T22:32:41Z

⚠️ Regressions detected on macos-14 for commit `5049249`

Regression Summary

Audit: 796
Table Big Diffs: 738

JasonGlazer · 2025-09-10T11:54:08Z

This new table only reports for airloop systems, not for zone systems such as fancoils. Is that adequate?

It is probably adequate, but there might be some cases that I'm not thinking of. How difficult would it be to support zone systems like fancoils?

mjwitte · 2025-09-10T15:27:03Z

This new table only reports for airloop systems, not for zone systems such as fancoils. Is that adequate?

It is probably adequate, but there might be some cases that I'm not thinking of. How difficult would it be to support zone systems like fancoils?

Not sure, the current accumulations are done at the airloop level. It could be added to a zone level reporting struct. I'm going to merge this PR as-is and add a new item to the RPD task list.

mjwitte · 2025-09-10T15:27:58Z

@rraustad Has looked at this previously. CI is happy, diffs as expected. Merging.

Extend equipment summary air heat recovery table

f60a290

mjwitte added NewFeature Includes code to add a new feature to EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze RPD labels Jul 30, 2025

mjwitte added 2 commits July 30, 2025 16:47

Extend equipment summary air heat recovery table more

44c0018

Extend equipment summary air heat recovery table fix unit tests

6a755a2

mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Aug 1, 2025

mjwitte added 2 commits August 6, 2025 10:58

Align IDD default with input code

5004a7f

Add more heat recovery logic

8042f5c

Output rules for Air Heat Recovery table

a7ea702

Add PIU heating and fan control types to Air Terminals subtable

b90b672

mjwitte changed the title ~~Extend equipment summary air heat recovery table~~ Extend Equipment Summary Tables - Air Heat Recovery and Air Terminals Aug 8, 2025

Set PIU fan control default to fix unit test

6ed175d

Add Speed Control Method and Number Speeds to Fans subtable

208bb25

mjwitte changed the title ~~Extend Equipment Summary Tables - Air Heat Recovery and Air Terminals~~ Extend Equipment Summary Tables - Air Heat Recovery, Air Terminals, and Fans Aug 8, 2025

Cleanup

ef2757f

mjwitte added 2 commits August 11, 2025 16:25

New System Summary report Fan Operation subtable

a7ea15f

New System Summary report Fan Operation subtable - output rules

dff2623

mjwitte changed the title ~~Extend Equipment Summary Tables - Air Heat Recovery, Air Terminals, and Fans~~ Extend Equipment and System Summary Tables - Air Heat Recovery, Air Terminals, and Fans Aug 11, 2025

mjwitte marked this pull request as ready for review August 11, 2025 21:40

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables4

8633c06

Address comments and fix PIU fan airloop name

439ef04

rraustad reviewed Aug 14, 2025

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables4

05ca9fd

mjwitte merged commit dc93b9d into develop Sep 10, 2025
7 of 8 checks passed

mjwitte deleted the rpdTables4 branch September 10, 2025 15:28

Extend Equipment and System Summary Tables - Air Heat Recovery, Air Terminals, and Fans #11138

Extend Equipment and System Summary Tables - Air Heat Recovery, Air Terminals, and Fans #11138

Conversation

mjwitte commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Jul 30, 2025

⚠️ Regressions detected on macos-14 for commit ce97f40

Uh oh!

github-actions bot commented Jul 31, 2025

⚠️ Regressions detected on macos-14 for commit 64adf5b

Uh oh!

github-actions bot commented Aug 6, 2025

⚠️ Regressions detected on macos-14 for commit 77ace05

Uh oh!

mjwitte commented Aug 7, 2025

Uh oh!

mjwitte commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

⚠️ Regressions detected on macos-14 for commit c80f755

Uh oh!

mjwitte commented Aug 8, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

⚠️ Regressions detected on macos-14 for commit 971aef8

Uh oh!

github-actions bot commented Aug 11, 2025

⚠️ Regressions detected on macos-14 for commit 059c5f3

Uh oh!

mjwitte commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 12, 2025

⚠️ Regressions detected on macos-14 for commit 04b25b2

Uh oh!

JasonGlazer commented Aug 12, 2025

Uh oh!

JasonGlazer commented Aug 12, 2025

Uh oh!

mjwitte commented Aug 13, 2025

Uh oh!

mjwitte commented Aug 13, 2025

Uh oh!

mjwitte commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

⚠️ Regressions detected on macos-14 for commit 9fcd85d

Uh oh!

rraustad Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

mjwitte Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

rraustad Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rraustad Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rraustad Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

mjwitte commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 5049249

Uh oh!

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on macos-14 for commit 5049249

Uh oh!

JasonGlazer commented Sep 10, 2025

Uh oh!

mjwitte commented Sep 10, 2025

Uh oh!

mjwitte commented Jul 30, 2025 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `ce97f40`

⚠️ Regressions detected on macos-14 for commit `64adf5b`

⚠️ Regressions detected on macos-14 for commit `77ace05`

⚠️ Regressions detected on macos-14 for commit `c80f755`

⚠️ Regressions detected on macos-14 for commit `971aef8`

⚠️ Regressions detected on macos-14 for commit `059c5f3`

⚠️ Regressions detected on macos-14 for commit `04b25b2`

⚠️ Regressions detected on macos-14 for commit `9fcd85d`

rraustad Aug 14, 2025 •

edited

Loading

rraustad Aug 14, 2025 •

edited

Loading

⚠️ Regressions detected on ubuntu-24.04 for commit `5049249`

⚠️ Regressions detected on macos-14 for commit `5049249`