Skip to content

Fix bad subscript in ZoneVentilation:DesignFlowRate warning #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjwitte merged 1 commit into from
Jul 29, 2025
Merged

Fix bad subscript in ZoneVentilation:DesignFlowRate warning #11133

mjwitte merged 1 commit into from
Jul 29, 2025

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Jul 25, 2025

Pull request overview

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Jul 25, 2025
rraustad
rraustad reviewed Jul 28, 2025
View reviewed changes
src/EnergyPlus/HeatBalanceAirManager.cc
state,
eoh,
format("Both {} and {} provided, {} will be used.", cAlphaFieldNames(10), cNumericFieldNames(15), cAlphaFieldNames(15)));
format("Both {} and {} provided, {} will be used.", cAlphaFieldNames(10), cNumericFieldNames(15), cAlphaFieldNames(10)));
Copy link
Contributor

@rraustad rraustad Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks correct, especially when A15 does not exist.

ZoneVentilation:DesignFlowRate,
  A9 , \field Minimum Outdoor Temperature Schedule Name
  N15, \field Maximum Outdoor Temperature
  A10, \field Maximum Outdoor Temperature Schedule Name
  N16; \field Maximum Wind Speed

@mjwitte mjwitte merged commit aa87688 into develop Jul 29, 2025
10 checks passed
@mjwitte mjwitte deleted the hotfix11132 branch July 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rraustad rraustad rraustad approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad allocation failure

4 participants

@mjwitte @rraustad @nrel-bot-2c