Fix a few EIO headers and newlines #11126

jmarrec · 2025-07-17T09:05:25Z

Pull request overview

Found in #10596 - Remove fmt fortran workarounds - Z & N (and S) #11109
I wrote an EIO parser and realized that some formats were broken

Description of the purpose of this PR

Pull Request Author

Reviewer

Found in #11109: I wrote an EIO parser and realized that some formats were broken

jmarrec · 2025-07-17T09:11:26Z

src/EnergyPlus/ConvectionCoefficients.cc

                "! <Building Convection Parameters:Roof>, Area [m2], Perimeter [m], Height [m], Tilt [deg], Azimuth [deg]\n");
            print(state.files.eio, Format_8800); // header for roof
-            static constexpr std::string_view Format_8801("Building Convection Parameters:Roof,{:.2R},{:.2R},{:.2R},{:.2R},{:.2R}");
+            static constexpr std::string_view Format_8801("Building Convection Parameters:Roof,{:.2R},{:.2R},{:.2R},{:.2R},{:.2R}\n");


EMSThermochromicWindow/eplusout.eio

! <Building Convection Parameters:Roof>, Area [m2], Perimeter [m], Height [m], Tilt [deg], Azimuth [deg] -Building Convection Parameters:Roof,598.76,97.10,3.28,18.45,120.62! <ZoneInfiltration Airflow Stats Nominal>,Name,Schedule Name,Zone Name, Zone Floor Area {m2}, # Zone Occupants,Design Volume Flow Rate {m3/s},Volume Flow Rate/Floor Area {m3/s-m2},Volume Flow Rate/Exterior Surface Area {m3/s-m2},ACH - Air Changes per Hour,Equation A - Constant Term Coefficient {},Equation B - Temperature Term Coefficient {1/C},Equation C - Velocity Term Coefficient {s/m}, Equation D - Velocity Squared Term Coefficient {s2/m2} +Building Convection Parameters:Roof,598.76,97.10,3.28,18.45,120.62 +! <ZoneInfiltration Airflow Stats Nominal>,Name,Schedule Name,Zone Name, Zone Floor Area {m2}, # Zone Occupants,Design Volume Flow Rate {m3/s},Volume Flow Rate/Floor Area {m3/s-m2},Volume Flow Rate/Exterior Surface Area {m3/s-m2},ACH - Air Changes per Hour,Equation A - Constant Term Coefficient {},Equation B - Temperature Term Coefficient {1/C},Equation C - Velocity Term Coefficient {s/m}, Equation D - Velocity Squared Term Coefficient {s2/m2}

jmarrec · 2025-07-17T09:12:36Z

src/EnergyPlus/DaylightingDevices.cc

                }
                print(state.files.eio,
-                      "{},{:.2R},{},{:.2R},{:.2R}\n",
+                      "Shelf Details,{},{:.2R},{},{:.2R},{:.2R}\n",


DaylightingDeviceShelf/eplusout.eio

! <Shelf Details>,Name,View Factor to Outside Shelf,Window Name,Window View Factor to Sky,Window View Factor to Ground -SHELF,0.29,DAYLIT UPPER WINDOW,0.50,0.21 +Shelf Details,SHELF,0.29,DAYLIT UPPER WINDOW,0.50,0.21

jmarrec · 2025-07-17T09:16:51Z

src/EnergyPlus/HeatBalanceAirManager.cc

        static constexpr std::string_view Format_724("! <{} Airflow Stats Nominal>, {}\n");
        print(state.files.eio,
              Format_724,
-              "RefrigerationDoorMixing ",
+              "RefrigerationDoorMixing",


Avoids double space in header

RefrigeratedWarehouse/eplusout.eio.

-! <RefrigerationDoorMixing Airflow Stats Nominal>, Name, Zone 1 Name,Zone 2 Name,Door Opening Schedule Name,Door Height {m},Door Area {m2},Door Protection Type +! <RefrigerationDoorMixing Airflow Stats Nominal>, Name, Zone 1 Name,Zone 2 Name,Door Opening Schedule Name,Door Height {m},Door Area {m2},Door Protection Type RefrigerationDoorMixing Airflow Stats Nominal, FREEZER1_SUBFREEZER1,FREEZER_1,SUBFREEZER,FREEZER1DOORSCHEDA,1.800,2.300,StripCurtain

jmarrec · 2025-07-17T09:18:09Z

src/EnergyPlus/PlantPipingSystemsManager.cc

            // Write eio data
            for (auto &thisDomain : state.dataPlantPipingSysMgr->domains) {
-                static constexpr std::string_view DomainCellsToEIO("{},{:5},{:5},{:5}\n");
+                static constexpr std::string_view DomainCellsToEIO("Domain Name,{},{:5},{:5},{:5}\n");


5ZoneAirCooledWithCoupledInGradeSlab/eplusout.eio

! <Domain Name>, Total Number of Domain Cells, Total Number of Ground Surface Cells, Total Number of Insulation Cells -INGRADECOUPLEDSLAB, 3380, 120, 182 +Domain Name,INGRADECOUPLEDSLAB, 3380, 120, 182

jmarrec · 2025-07-17T09:19:01Z

src/EnergyPlus/RefrigeratedCase.cc

        "Node #,Zone Node Name,Sensible Capacity (W/C),Sensible Capacity (W),Evaporating Temperature (C),DT1 (C),Fan "
        "Power (W),Heater (W),Defrost (W), Air Flow Rate (m3/s)");
-    static constexpr std::string_view Format_152("!  <Air Chiller Load>, Air Chiller Name, Air Chiller Number, Zone Name,");
+    static constexpr std::string_view Format_152("!  <Air Chiller Load>, Air Chiller Name, Air Chiller Number, Zone Name");


RefrigeratedWarehouse/eplusout.eio

Most parsers (eg pandas) would assume there's an extra unnamed column at the end due to the extra comma.

jmarrec · 2025-07-17T09:20:09Z

src/EnergyPlus/WindowManager.cc

                      "Set Name, Front Side Beam-Beam Solar Transmittance, Back Side Beam-Beam Solar Transmittance, "
                      "Front Side Beam-Beam Solar Reflectance, Back Side Beam-Beam Solar Reflectance, Front Side "
-                      "Beam-Diffuse Solar Transmittance, Back Side Beam-Diffuse Solar Transmittance, , Front Side "
+                      "Beam-Diffuse Solar Transmittance, Back Side Beam-Diffuse Solar Transmittance, Front Side "


EquivalentLayerWindow/eplusout.eio

-! <WindowMaterial:Glazing:EquivalentLayer>, Material Name, Optical Data Type, Spectral Data Set Name, Front Side Beam-Beam Solar Transmittance, Back Side Beam-Beam Solar Transmittance, Front Side Beam-Beam Solar Reflectance, Back Side Beam-Beam Solar Reflectance, Front Side Beam-Diffuse Solar Transmittance, Back Side Beam-Diffuse Solar Transmittance, , Front Side Beam-Diffuse Solar Reflectance, Back Side Beam-Diffuse Solar Reflectance, Diffuse-Diffuse Solar Transmittance, Front Side Diffuse-Diffuse Solar Reflectance, Back Side Diffuse-Diffuse Solar Reflectance, Infrared Transmittance, Front Side Infrared Emissivity, Back Side Infrared Emissivity +! <WindowMaterial:Glazing:EquivalentLayer>, Material Name, Optical Data Type, Spectral Data Set Name, Front Side Beam-Beam Solar Transmittance, Back Side Beam-Beam Solar Transmittance, Front Side Beam-Beam Solar Reflectance, Back Side Beam-Beam Solar Reflectance, Front Side Beam-Diffuse Solar Transmittance, Back Side Beam-Diffuse Solar Transmittance, Front Side Beam-Diffuse Solar Reflectance, Back Side Beam-Diffuse Solar Reflectance, Diffuse-Diffuse Solar Transmittance, Front Side Diffuse-Diffuse Solar Reflectance, Back Side Diffuse-Diffuse Solar Reflectance, Infrared Transmittance, Front Side Infrared Emissivity, Back Side Infrared Emissivity

Extract:

-Back Side Beam-Diffuse Solar Transmittance, , Front Side Beam-Diffuse Solar Reflectance +Back Side Beam-Diffuse Solar Transmittance, Front Side Beam-Diffuse Solar Reflectance

jmarrec · 2025-07-17T09:44:32Z

src/EnergyPlus/WaterThermalTanks.cc

                print(state.files.eio, Format_722);
            }
-            if (state.dataWaterThermalTanks->numChilledWaterMixed > 0) {
+            if ((state.dataWaterThermalTanks->numChilledWaterMixed > 0) || (state.dataWaterThermalTanks->numChilledWaterStratified > 0)) {


5ZoneVAV-ChilledWaterStorage-Stratified/eplusout.eio

The Chilled Water Tank Information value line is issued, but not the header.

$ rg "Chilled Water Tank" 5ZoneVAV-ChilledWaterStorage-Stratified/eplusout.eio 197:! <Chilled Water Tank Stratified Node Information>,Node Number,Height {m},Volume {m3},UA {W/K},Number Of Inlets,Number Of Outlets 399:Chilled Water Tank Stratified Node Information,1,1.3333,8.3333,9.0331,1,1 400:Chilled Water Tank Stratified Node Information,2,1.3333,8.3333,5.9081,0,0 401:Chilled Water Tank Stratified Node Information,3,1.3333,8.3333,5.9081,0,0 402:Chilled Water Tank Stratified Node Information,4,1.3333,8.3333,5.9081,0,0 403:Chilled Water Tank Stratified Node Information,5,1.3333,8.3333,5.9081,0,0 404:Chilled Water Tank Stratified Node Information,6,1.3333,8.3333,9.0331,1,1 416:Chilled Water Tank Information,ThermalStorage:ChilledWater:Stratified,CHILLED WATER STORAGE TANK 1,50.0000,3.0227E-003,5.0000E-003

jmarrec · 2025-07-17T09:46:13Z

src/EnergyPlus/SimulationManager.cc

            "Parallel Sims");
        print(state.files.eio, "{}\n", ThreadingHeader);
-        static constexpr std::string_view ThreadReport("Program Control:Threads/Parallel Sims, {},{}, {}, {}, {}, {}, {}, {}\n");
+        static constexpr std::string_view ThreadReport("Program Control Information:Threads/Parallel Sims, {},{}, {}, {}, {}, {}, {}, {}\n");


Align with header.

Example 1ZoneUncontrolled/eplusout.eio

! <Program Control Information:Threads/Parallel Sims>, Threading Supported,Maximum Number of Threads, Env Set Threads (OMP_NUM_THREADS), EP Env Set Threads (EP_OMP_NUM_THREADS), IDF Set Threads, Number of Threads Used (Interior Radiant Exchange), Number Nominal Surfaces, Number Parallel Sims -Program Control:Threads/Parallel Sims, No,1, N/A, N/A, N/A, N/A, N/A, N/A +Program Control Information:Threads/Parallel Sims, No,1, N/A, N/A, N/A, N/A, N/A, N/A

github-actions · 2025-07-17T10:07:24Z

⚠️ Regressions detected on macos-14 for commit `ca5e4c5`

Regression Summary

EIO: 11
Table String Diffs: 2
Table Big Diffs: 1

github-actions · 2025-07-17T10:46:29Z

⚠️ Regressions detected on macos-14 for commit `63ee844`

Regression Summary

EIO: 793
Table String Diffs: 2
Table Big Diffs: 1

jmarrec · 2025-07-17T11:30:14Z

EIO diffs in all files are expected

--- 
+++ 
@@ -551,5 +551,5 @@
 -different, but equivalent numeric tokens found in line-
 -different, but equivalent numeric tokens found in line-
 ! , Threading Supported,Maximum Number of Threads, Env Set Threads (OMP_NUM_THREADS), EP Env Set Threads (EP_OMP_NUM_THREADS), IDF Set Threads, Number of Threads Used (Interior Radiant Exchange), Number Nominal Surfaces, Number Parallel Sims
-Program Control:Threads/Parallel Sims, No,1, N/A, N/A, N/A, N/A, N/A, N/A
+Program Control Information:Threads/Parallel Sims, No,1, N/A, N/A, N/A, N/A, N/A, N/A
 End of Data

Myoldmopar

This seems like an easy set of changes. My one thought is that we should have a couple worker functions to send data to the EIO instead of directly printing from it. It would be nice to not have to carefully format everything on each of these calls, and instead just pass a vector of stuff in and let it handle it. I realize there may be complications, but it would be nice to centralize it into a very minimal set of workers. That's for later, thanks @jmarrec

Myoldmopar · 2025-07-22T17:48:44Z

I've got no issue with this cleanup. CI is happy and I think I'll just drop this right in.

Fix a few EIO headers and newlines

611ed86

Found in #11109: I wrote an EIO parser and realized that some formats were broken

jmarrec self-assigned this Jul 17, 2025

jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Jul 17, 2025

jmarrec commented Jul 17, 2025

View reviewed changes

jmarrec requested a review from Myoldmopar July 17, 2025 09:21

jmarrec added 2 commits July 17, 2025 11:37

Align header in EIO

5726453

Missing header line in case of Stratified CW Tank

58e72aa

jmarrec commented Jul 17, 2025

View reviewed changes

Myoldmopar approved these changes Jul 22, 2025

View reviewed changes

Myoldmopar merged commit 403d65c into develop Jul 22, 2025
9 checks passed

Myoldmopar deleted the eio_fixes branch July 22, 2025 17:48

Fix a few EIO headers and newlines #11126

Fix a few EIO headers and newlines #11126

Uh oh!

Conversation

jmarrec commented Jul 17, 2025

Pull request overview

Description of the purpose of this PR

Pull Request Author

Reviewer

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 17, 2025

⚠️ Regressions detected on macos-14 for commit ca5e4c5

Uh oh!

github-actions bot commented Jul 17, 2025

⚠️ Regressions detected on macos-14 for commit 63ee844

Uh oh!

jmarrec commented Jul 17, 2025

Uh oh!

Myoldmopar left a comment

Choose a reason for hiding this comment

Uh oh!

Myoldmopar commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

⚠️ Regressions detected on macos-14 for commit `ca5e4c5`

⚠️ Regressions detected on macos-14 for commit `63ee844`