Skip to content

Inconsistent field names and field name typo in different VS DX coils #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myoldmopar merged 4 commits into from
Jun 5, 2025
Merged

Inconsistent field names and field name typo in different VS DX coils #11075

Myoldmopar merged 4 commits into from
Jun 5, 2025

Conversation

@Nigusse
Copy link
Contributor

@Nigusse Nigusse commented May 20, 2025

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Nigusse Nigusse added the Defect Includes code to repair a defect in EnergyPlus label May 20, 2025
@Nigusse
Copy link
Contributor Author

Nigusse commented May 20, 2025

These changes are not expected to cause any results diffs but create inconvenience when you implement to read JSON format inputs.

Nigusse
Nigusse commented May 20, 2025
View reviewed changes
Copy link
Contributor Author

@Nigusse Nigusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adrsses inconsistent field names and field name typos in four VS DX coils.

idd/Energy+.idd.in
\maximum 1505.0
\default 934.4
N94, \field Speed 10 Reference Unit Condenser Air Flow Rate
N94, \field Speed 10 Reference Unit Rated Condenser Air Flow Rate
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing text "Rated" for speeds 6 through 10 for VS DX cooling coil.

idd/Energy+.idd.in
\note db = entering air dry-bulb temperature (C)
\note oat = air entering temperature seen by the evaporator (C)
A18, \field Speed 3 Total Heating Capacity Function of Air Flow Fraction Curve Name
A18, \field Speed 3 Total Heating Capacity Function of Air Flow Fraction Curve Name
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra space between words for speeds 1 to 3.

idd/Energy+.idd.in
\note db = entering air dry-bulb temperature (C)
\note oat = air entering temperature seen by the evaporator (C)
A46, \field Speed 10 Heating Capacity Function of Air Flow Fraction Curve Name
A46, \field Speed 10 Total Heating Capacity Function of Air Flow Fraction Curve Name
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the text "Total" for speeds 3 through 10 for VS DX heating coil.

idd/Energy+.idd.in
\minimum> 0.0
\required-field
N8, \field Speed 1 Reference Unit Rated Air Flow
N8, \field Speed 1 Reference Unit Rated Air Flow Rate
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing test "Rate" for speed 1 in VS DX heating coil in WAHP object.

idd/Energy+.idd.in
\note db = entering air dry-bulb temperature (C)
\note ewt = water entering temperature seen by the evaporator (C)
A71, \field Speed 10 Total Heating Capacity Function of Air Flow Fraction Curve Name
A71, \field Speed 10 Total Heating Capacity Function of Air Flow Fraction Curve Name
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra space between words for speeds 1 through 10 in VS EquationFit DX heating coil in WAHP object.

idd/Energy+.idd.in
\note rated condenser inlet water temperature, rated air flow rate, and rated water flow rate.
\note Can optionally include condenser pump power and evaporator fan power (see fields below).
N14, \field Rated Sensible Heat Ratio at Speed 1
N14, \field Speed 1 Rated Sensible Heat Ratio
Copy link
Contributor Author

@Nigusse Nigusse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes inconsistent field names for speeds 1 to 3 for VS Water Heating AtoWHP object

@Nigusse Nigusse added this to the EnergyPlus 25.2 milestone May 20, 2025
@Myoldmopar
Copy link
Member

Myoldmopar commented Jun 5, 2025

Thanks @Nigusse, this is dropping right in. If we could train up the W.I.T.T.E. to detect mismatched field names, that would be helpful :)

@Myoldmopar Myoldmopar merged commit d10c11f into develop Jun 5, 2025
9 of 10 checks passed
@Myoldmopar Myoldmopar deleted the Issue11056_IDDTypo branch June 5, 2025 14:47
@mjwitte mjwitte mentioned this pull request Jul 1, 2025
Closed
@Nigusse
Copy link
Contributor Author

Nigusse commented Jul 1, 2025 •
edited
Loading

PR #11012 also addressed additional field name typos in the Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object for the following three extensible fields in this commit. The changes affect speeds 2 through 10.

N18, \field Rated Water Heating Capacity at Speed X
N19, \field Rated Water Heating COP at Speed X
N20, \field Rated Sensible Heat Ratio at Speed X

The fields were renamed as follows:

N18, \field Speed X Rated Water Heating Capacity
N19, \field Speed X Rated Water Heating COP
N20, \field Speed X Rated Sensible Heat Ratio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

VS DX Coils Field Names Has Inconsistency and Field Name Typos

4 participants

@Nigusse @Myoldmopar @nrel-bot-2