Skip to content

Missing references in IDD #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myoldmopar merged 1 commit into from
May 21, 2025
Merged

Missing references in IDD #11069

Myoldmopar merged 1 commit into from
May 21, 2025

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented May 19, 2025

Pull request overview

Description of the purpose of this PR

Add missing reference to the IDD file.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels May 19, 2025
@lymereJ lymereJ added this to the EnergyPlus 25.2 IO Freeze milestone May 19, 2025
Myoldmopar
Myoldmopar approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections here. Anything else to add @lymereJ or any objections from anyone?

idd/Energy+.idd.in
\reference HeatingCoilsWaterToAirVSHP
\reference-class-name validBranchEquipmentTypes
\reference validBranchEquipmentNames
\reference AFNCoilNames
Copy link
Member

@Myoldmopar Myoldmopar May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem...fine. As long as they are supported coils for the AFN now, which I suppose they are after looking at the Solver code.

idd/Energy+.idd.in
A1 , \field Name
\required-field
\reference-class-name validBranchEquipmentTypes
\reference validBranchEquipmentNames
Copy link
Member

@Myoldmopar Myoldmopar May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fine.

@lymereJ
Copy link
Collaborator Author

lymereJ commented May 21, 2025

No objections here. Anything else to add @lymereJ or any objections from anyone?

Nothing else from me. Thanks.

@Myoldmopar
Copy link
Member

Myoldmopar commented May 21, 2025

Thanks @lymereJ

@Myoldmopar Myoldmopar merged commit 17f692d into develop May 21, 2025
8 checks passed
@Myoldmopar Myoldmopar deleted the missing_idd_fields branch May 21, 2025 17:52
@jmarrec jmarrec mentioned this pull request Oct 22, 2025
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Milestone

EnergyPlus 25.2 IO Freeze

Development

Successfully merging this pull request may close these issues.

4 participants

@lymereJ @Myoldmopar @nrel-bot-2c