Skip to content

Fix Coil Sizing Report for Coil:Heating:Gas:MultiStage and Coil:Heating:Electric:MultiStage #11063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myoldmopar merged 2 commits into from
May 21, 2025
Merged

Fix Coil Sizing Report for Coil:Heating:Gas:MultiStage and Coil:Heating:Electric:MultiStage #11063

Myoldmopar merged 2 commits into from
May 21, 2025

Conversation

@amirroth
Copy link
Collaborator

@amirroth amirroth commented May 17, 2025 •
edited
Loading

Pull request overview

Description of the purpose of this PR

@github-actions
Copy link

github-actions bot commented May 17, 2025

⚠️ Regressions detected on macos-14 for commit bb922c1

Regression Summary
  • EIO: 1
  • Table Big Diffs: 1
  • Table String Diffs: 1

@github-actions
Copy link

github-actions bot commented May 17, 2025

⚠️ Regressions detected on macos-14 for commit 51daeb7

Regression Summary
  • EIO: 6
  • Table Big Diffs: 6
  • Table String Diffs: 6

@amirroth amirroth changed the title Fix Coil Sizing Report for Coil:Heating:Gas:MultiStage Fix Coil Sizing Report for Coil:Heating:Gas:MultiStage and Coil:Heating:Electric:MultiStage May 17, 2025
@amirroth amirroth added the Defect Includes code to repair a defect in EnergyPlus label May 17, 2025
@amirroth amirroth added this to the EnergyPlus 25.2 milestone May 17, 2025
@amirroth amirroth requested a review from rraustad May 17, 2025 20:46
amirroth
amirroth commented May 17, 2025
View reviewed changes
src/EnergyPlus/HeatingCoils.cc

heatingCoil.HeatingCoilType = "Heating";
heatingCoil.HeatingCoilModel = "ElectricMultiStage";
heatingCoil.HeatingCoilModel = "Electric:MultiStage";
Copy link
Collaborator Author

@amirroth amirroth May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in a CompType of Coil:Heating:ElectricMultistage in the sizing routines which leads to information in the CoilSelectionReport object to be ignored because that is not a valid coil type name.

@amirroth amirroth mentioned this pull request May 19, 2025
Closed
rraustad
rraustad approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@amirroth amirroth assigned amirroth and rraustad and unassigned amirroth May 19, 2025
@rraustad
Copy link
Contributor

rraustad commented May 19, 2025 •
edited
Loading

Diffs are attributed to correction of coil type:

- Component Sizing Information, Coil:Heating:GasMultiStage, HEAT PUMP HEATING COIL 1, User-Specified Stage 1 Nominal Capacity [W], 45000.00000
+ Component Sizing Information, Coil:Heating:Gas:MultiStage, HEAT PUMP HEATING COIL 1, User-Specified Stage 1 Nominal Capacity [W], 45000.00000

Need to check what the result is from this branch for:

image

@rraustad
Copy link
Contributor

rraustad commented May 19, 2025

There are still issues with the reporting of sizing data but the coil type has been corrected. Total and Sensible capacity should both show 45000 W and the air flow and conditions used during sizing should be reported correctly, this is a separate issue.

Component Sizing Information, Coil:Heating:Gas:MultiStage, HEAT PUMP HEATING COIL 1, User-Specified Stage 1 Nominal Capacity [W], 45000.00000

image

@amirroth
Copy link
Collaborator Author

amirroth commented May 19, 2025

I do not know how to address this other issue. Someone else will have to do that.

@rraustad
Copy link
Contributor

rraustad commented May 20, 2025

@Myoldmopar this branch is ready to merge.

@Myoldmopar
Copy link
Member

Myoldmopar commented May 21, 2025

Looks like Decent decided it wanted one more pass here. I'll give it a few more minutes, then this can merge.

@Myoldmopar
Copy link
Member

Myoldmopar commented May 21, 2025

Alright, good to go in. Thanks @amirroth and @rraustad

@Myoldmopar Myoldmopar merged commit c6e3438 into develop May 21, 2025
9 of 10 checks passed
@Myoldmopar Myoldmopar deleted the FixCoilHeatingGasMultiStageReport branch May 21, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rraustad rraustad rraustad approved these changes

Assignees

@rraustad rraustad

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

Incorrect Coil Sizing Report for Coil:Heating:Gas:MultiStage

6 participants

@amirroth @rraustad @Myoldmopar @nrel-bot-2 @nrel-bot-2c