Skip to content

Conversation

@Nigusse
Copy link
Contributor

@Nigusse Nigusse commented Mar 6, 2025

Pull request overview

  • New Feature

Description of the purpose of this PR

Adds availability schedule input field to the DX coils lacking one. Currently, there are eleven DX heating and cooling coil objects missing availability schedule input field.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Nigusse Nigusse added the NewFeature Includes code to add a new feature to EnergyPlus label Mar 6, 2025
@shorowit
Copy link
Contributor

shorowit commented Mar 6, 2025

Note that Coil:Cooling:DX has an input but it's not actually used. Can that be addressed as part of this? See #10884

@Nigusse
Copy link
Contributor Author

Nigusse commented Mar 7, 2025

Note that Coil:Cooling:DX has an input but it's not actually used. Can that be addressed as part of this? See #10884

If the budget allows, we will address it.

@Myoldmopar
Copy link
Member

Merging this NFP only change.

@Myoldmopar Myoldmopar merged commit f44177c into develop Apr 9, 2025
6 checks passed
@Myoldmopar Myoldmopar deleted the avail_schedule_missing_DX_coils branch April 9, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants