Skip to content

Conversation

@yzhou601
Copy link
Contributor

@yzhou601 yzhou601 commented Mar 4, 2025

Pull request overview

  • Fixes #ISSUENUMBERHERE

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@yzhou601 yzhou601 added the NewFeature Includes code to add a new feature to EnergyPlus label Mar 4, 2025
@yzhou601 yzhou601 added this to the EnergyPlus 25.1 milestone Mar 4, 2025
@yzhou601 yzhou601 self-assigned this Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

⚠️ Regressions detected on macos-14 for commit 28233fc

Regression Summary
  • Audit: 9
  • EDD: 5

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

⚠️ Regressions detected on macos-14 for commit 5e47358

Regression Summary
  • Audit: 9
  • EDD: 5

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

⚠️ Regressions detected on macos-14 for commit 41d49a5

Regression Summary
  • Audit: 9
  • EDD: 5

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

⚠️ Regressions detected on macos-14 for commit 5fa3b3f

Regression Summary
  • Audit: 9
  • EDD: 5

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 067df05

Regression Summary
  • Audit: 9
  • EDD: 5

@yzhou601
Copy link
Contributor Author

Manual test for Coil:DX:Heating:SingleSpeed, Coil:DX:Heating:MultiSpeed, with a simple EMS program to set the frost capacity multiplier to be 0.2, frost power multiplier to be 0.4, compared to the original E+ coil simulation (reverse strategy, timed defrost control)
Single speed results:

  • delivered heating:
    image
    Results show that the heating capacity is limited by the EMS frost cap multiplier
  • heating power:
    image
    Results show that the heating power is limited by the EMS frost power multiplier
  • defrost power
    image
    Results show higher defrost power because of the increase of run time fraction (caused by limiting capacity)

Similar results for multi-speed system test:

  • delivered heating:
    image
  • heating power:
    image
  • defrost power
    image

Test IDFs:
in-simple-frost-multispeed.idf.txt
in-original-1-speed.idf.txt
in-original-multispeed.idf.txt
in-simple-frost-1speed.idf.txt

@yzhou601 yzhou601 marked this pull request as ready for review March 15, 2025 01:42
@yzhou601
Copy link
Contributor Author

This is ready for review

@Myoldmopar
Copy link
Member

All good here, will do a quick pull with develop to confirm, but this should merge shortly.

@Myoldmopar
Copy link
Member

Twas all happy locally, merging this.

@Myoldmopar Myoldmopar merged commit 77e10fe into develop Mar 17, 2025
9 checks passed
@Myoldmopar Myoldmopar deleted the frost_multiplier branch March 17, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants