Skip to content

Add severe error when crankcase heater curve name is invalid #10963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjwitte merged 3 commits into from
Mar 3, 2025
Merged

Add severe error when crankcase heater curve name is invalid #10963

mjwitte merged 3 commits into from
Mar 3, 2025

Conversation

@yujiex
Copy link
Collaborator

@yujiex yujiex commented Feb 28, 2025 •
edited by mjwitte
Loading

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@yujiex yujiex added the Defect Includes code to repair a defect in EnergyPlus label Feb 28, 2025
@yujiex yujiex requested a review from mjwitte February 28, 2025 02:13
@yujiex yujiex self-assigned this Feb 28, 2025
mjwitte
mjwitte approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the defect file. Now there's a severe error:

   ** Severe  ** Coil:Cooling:DX:CurveFit:Performance = HEAT PUMP ACDXCOIL 1 PERFORMANCE:  Crankcase Heater Capacity Function of Temperature Curve Name not found = XYZ
   **  Fatal  ** CoilCoolingDXCurveFitOperatingMode::instantiateFromInputSpecErrors found in getting Coil:Cooling:DX:CurveFit:Performance input. Preceding condition(s) causes termination.

CI is all green. Merging. Thanks @yujiex

@mjwitte mjwitte merged commit 9814fa5 into develop Mar 3, 2025
10 checks passed
@mjwitte mjwitte deleted the fixCrankcaseHeaterCurveNameErr branch March 3, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjwitte mjwitte mjwitte approved these changes

Assignees

@yujiex yujiex

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid Crankcase Heater Capacity Function of Outdoor Temperature Curve Name will crash

5 participants

@yujiex @mjwitte @nrel-bot-2 @nrel-bot-2c