Skip to content

Add output columns and tables for ruleset project description work #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitchute merged 58 commits into from
Sep 30, 2025
Merged

Add output columns and tables for ruleset project description work #10949

mitchute merged 58 commits into from
Sep 30, 2025

Conversation

@JasonGlazer
Copy link
Contributor

@JasonGlazer JasonGlazer commented Feb 21, 2025

Pull request overview

This pull request is related to the new feature proposal for enhancing the createRPD script located in a different repo:

https://github.com/JasonGlazer/createRulesetProjectDescription

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@JasonGlazer JasonGlazer added the NewFeature Includes code to add a new feature to EnergyPlus label Feb 21, 2025
@JasonGlazer JasonGlazer self-assigned this Feb 21, 2025
@JacksonJ-KC
Copy link

JacksonJ-KC commented Feb 24, 2025

I am wondering if any of the items in this list could avoid needing new outputs from EnergyPlus if the createRulesetProjectDescription script was able to extract data directly from the .sql or .eio files rather than JSON reports?

@JasonGlazer
Copy link
Contributor Author

JasonGlazer commented Feb 25, 2025

I am wondering if any of the items in this list could avoid needing new outputs from EnergyPlus if the createRulesetProjectDescription script was able to extract data directly from the .sql or .eio files rather than JSON reports?

Unfortunately, there is nothing in the SQL that I know of that is not already in the JSON output files that I'm using. The EIO is almost completely replicated in the tabular report as the Initialization Summary.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Mar 26, 2025

@JasonGlazer @Myoldmopar it has been 28 days since this pull request was last updated.

2 similar comments
@nrel-bot-2
Copy link

nrel-bot-2 commented Apr 23, 2025

@JasonGlazer @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented May 21, 2025

@JasonGlazer @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 25, 2025

@JasonGlazer @Myoldmopar it has been 34 days since this pull request was last updated.

@JasonGlazer JasonGlazer added the RPD label Jul 7, 2025
JasonGlazer added 11 commits July 9, 2025 13:32
@JasonGlazer
Merge branch 'develop' into Ruleset-createRPD-Ph4
4114d0e
@JasonGlazer
Starting to update the NFP for new output reports
03fa386
@JasonGlazer
Add heat recovery table change to NFP
e25347c
@JasonGlazer
More NFP changes
24790f6
@JasonGlazer
More reports added to NFP-RulesetProjectDescriptionPhase4.md [decent_…
af0c6d4 
…ci_skip] [actions skip]
@JasonGlazer
In NFP identify new columns that could be read from input [decent_ci_…
b5d8295 
…skip] [actions skip]
@JasonGlazer
Fixes to NFP [decent_ci_skip] [actions skip]
e4ab142
@JasonGlazer
Merge branch 'develop' into Ruleset-createRPD-Ph4
55bc18d
@JasonGlazer
Fix EIO Schedule - Hourly to be friendlier to IntializationSummary re…
ea1a865 
…porting columns
@JasonGlazer
Add more columns to Schedule-Hourly and document changes to output.
f7c3558
@JasonGlazer
Update NFP related to no longer needing the initialization summary sc…
d5184fb 
…hedule change
@github-actions
Copy link

github-actions bot commented Jul 21, 2025

⚠️ Regressions detected on macos-14 for commit 54db1d5

Regression Summary
  • EIO: 21
  • Table Big Diffs: 18

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

⚠️ Regressions detected on macos-14 for commit a0d0f2b

Regression Summary
  • Audit: 796
  • Table Big Diffs: 738
  • EIO: 453

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

⚠️ Regressions detected on macos-14 for commit 7f9bf9a

Regression Summary
  • Audit: 796
  • Table Big Diffs: 738
  • EIO: 453
  • ERR: 52
  • PERF_LOG: 1

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 7f9bf9a

Regression Summary
  • Audit: 799
  • EIO: 454
  • Table Big Diffs: 740
  • ERR: 52
  • PERF_LOG: 1

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

⚠️ Regressions detected on macos-14 for commit 650f113

Regression Summary
  • Audit: 795
  • Table Big Diffs: 738
  • EIO: 453

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 650f113

Regression Summary
  • Audit: 799
  • EIO: 454
  • Table Big Diffs: 740

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit b39b883

Regression Summary
  • Audit: 799
  • EIO: 454
  • Table Big Diffs: 740

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

⚠️ Regressions detected on macos-14 for commit b39b883

Regression Summary
  • Audit: 795
  • Table Big Diffs: 738
  • EIO: 453

@JasonGlazer
Copy link
Contributor Author

JasonGlazer commented Sep 16, 2025

@mjwitte and @Myoldmopar I think this is ready for review again.

@mitchute mitchute removed the request for review from Myoldmopar September 24, 2025 18:26
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on macos-14 for commit 61edc15

Regression Summary
  • Audit: 795
  • Table Big Diffs: 738
  • EIO: 453

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 61edc15

Regression Summary
  • Audit: 799
  • EIO: 454
  • Table Big Diffs: 740

@JasonGlazer
Copy link
Contributor Author

JasonGlazer commented Sep 24, 2025

@mjwitte this came back clean, so it is ready for your review.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

⚠️ Regressions detected on macos-14 for commit f3a5781

Regression Summary
  • Audit: 796
  • Table Big Diffs: 739
  • EIO: 453

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit f3a5781

Regression Summary
  • Audit: 800
  • EIO: 454
  • Table Big Diffs: 741

mitchute
mitchute approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a minor fixup and did a couple spot checks on table outputs. This all looks OK to me. We'll give CI another round, and then merge this.

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

⚠️ Regressions detected on macos-14 for commit a9d8837

Regression Summary
  • Audit: 798
  • Table Big Diffs: 741
  • EIO: 454

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit a9d8837

Regression Summary
  • Audit: 802
  • EIO: 455
  • Table Big Diffs: 743
  • MTD: 78
  • RDD: 75
  • BND: 4

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

⚠️ Regressions detected on macos-14 for commit 2886292

Regression Summary
  • Audit: 798
  • Table Big Diffs: 741
  • EIO: 454

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 2886292

Regression Summary
  • Audit: 802
  • EIO: 455
  • Table Big Diffs: 743

@mitchute mitchute merged commit 4ac1038 into develop Sep 30, 2025
11 checks passed
@mitchute mitchute deleted the Ruleset-createRPD-Ph4 branch September 30, 2025 00:34
@mjwitte mjwitte changed the title NFP for ruleset project description work and add output columns and tables Add output columns and tables for ruleset project description work Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute approved these changes

@mjwitte mjwitte Awaiting requested review from mjwitte

Assignees

@JasonGlazer JasonGlazer

Labels

NewFeature Includes code to add a new feature to EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze RPD

Projects

None yet

Milestone

EnergyPlus 25.2 IO Freeze

Development

Successfully merging this pull request may close these issues.

7 participants

@JasonGlazer @JacksonJ-KC @nrel-bot-2c @nrel-bot-2 @mjwitte @mitchute