Skip to content

Fix excess fluid properties warnings leading to huge err file size #10939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myoldmopar merged 1 commit into from
Feb 14, 2025
Merged

Fix excess fluid properties warnings leading to huge err file size #10939

Myoldmopar merged 1 commit into from
Feb 14, 2025

Conversation

@rraustad
Copy link
Contributor

@rraustad rraustad commented Feb 13, 2025 •
edited
Loading

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Feb 13, 2025
rraustad
rraustad commented Feb 13, 2025
View reviewed changes
src/EnergyPlus/FluidProperties.cc
// Error handling
if (error != GlycolError::Invalid && !state.dataGlobal->WarmupFlag) {
df->glycolErrorLimits[(int)error] = this->errors[(int)error].count;
df->glycolErrorLimits[(int)error] = ++this->errors[(int)error].count;
Copy link
Contributor Author

@rraustad rraustad Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is df->glycolErrorLimits[ ] even needed? Line 4201 could be:

if (++this->errors[(int)error].count <= df->GlycolErrorLimitTest) {

Copy link
Member

@Myoldmopar Myoldmopar Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fine question, but this definitely cleaned up those files. I'm going to get this merged but if you want to continue investigating if glycolErrorLimits is really needed, that can happen later.

@github-actions
Copy link

github-actions bot commented Feb 14, 2025

⚠️ Regressions detected on macos-14 for commit 4a5a270

Regression Summary
  • ERR: 6

@rraustad
Copy link
Contributor Author

rraustad commented Feb 14, 2025

Thanks to CI for finding a defect file. PipeHeatTransfer_Outair shows the issue with a 71 kB err file. This branch shows a 4 kB error file:

** Warning ** GlycolProps::getSpecificHeat: Temperature is out of range (too low) for fluid [WATER] specific heat supplied values **
**   ~~~   ** ..Called From:NodeReportingCalc:HTPIPE OUTLET NODE,Temperature=[-17.30], supplied data range=[0.00,125.00]
**   ~~~   **  Environment=CHICAGO_IL_USA ANNUAL HEATING 99% DESIGN CONDITIONS DB, at Simulation time=01/21 00:00 - 00:15
** Warning ** GlycolProps::getDensity: Temperature is out of range (too low) for fluid [WATER] density **
**   ~~~   ** ..Called From:NodeReportingCalc:HTPIPE OUTLET NODE,Temperature=[-17.30], supplied data range=[0.00,100.00]
**   ~~~   **  Environment=CHICAGO_IL_USA ANNUAL HEATING 99% DESIGN CONDITIONS DB, at Simulation time=01/21 00:00 - 00:15
************* Simulation Error Summary *************
*************
************* ===== Recurring Error Summary =====
************* The following recurring error messages occurred.
*************
*************  ** Warning ** GlycolProps::getSpecificHeat: Temperature out of range (too low) for fluid [WATER] specific heat **
*************  **   ~~~   **   This error occurred 1 total times;
*************  **   ~~~   **   during Warmup 0 times;
*************  **   ~~~   **   during Sizing 0 times.
*************  **   ~~~   **   Max=-17.300000 {C}  Min=-17.300000 {C}
*************
*************  ** Warning ** GlycolProps::getDensity: Temperature out of range (too low) for fluid [WATER] density **
*************  **   ~~~   **   This error occurred 192 total times;
*************  **   ~~~   **   during Warmup 0 times;
*************  **   ~~~   **   during Sizing 0 times.
*************  **   ~~~   **   Max=-17.300000 {C}  Min=-17.300000 {C}
*************

@rraustad rraustad added this to the EnergyPlus 25.1 milestone Feb 14, 2025
@Myoldmopar Myoldmopar merged commit cb200d6 into develop Feb 14, 2025
10 checks passed
@Myoldmopar Myoldmopar deleted the Fix-excess-fluid-properties-warnings branch February 14, 2025 19:24
@shorowit shorowit mentioned this pull request Aug 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.1

Development

Successfully merging this pull request may close these issues.

Fluid properties reports temperature out of range for every occurrence leading to very large err file size

4 participants

@rraustad @Myoldmopar @nrel-bot-2