Skip to content

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Jan 27, 2025

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Jan 27, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.1 IO Freeze milestone Jan 27, 2025
@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Jan 27, 2025
@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 423bac3

Regression Summary
  • Audit: 794

@mjwitte mjwitte changed the title Add Space and some Zone columns to Envelope Summary Add Space and Zone columns to Envelope Summary Jan 30, 2025
@mjwitte
Copy link
Contributor Author

mjwitte commented Jan 30, 2025

Regression diffs are all audit diffs like this
image

And in the table diff summary
image

@mjwitte
Copy link
Contributor Author

mjwitte commented Jan 30, 2025

Changes to the tables look like this.
Develop - some sub-tables have a column for Zone, some don't:
image
image
image
image
image

This branch - every sub-table has columns for both Zone and Space:
image
image
image
image
image

PR10914 ExampleFileTests.zip

@mjwitte mjwitte marked this pull request as ready for review January 30, 2025 22:45
@mjwitte mjwitte requested a review from JasonGlazer January 30, 2025 22:45
@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 099f2ab

Regression Summary
  • Audit: 794

Copy link
Contributor

@JasonGlazer JasonGlazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good change to make and the code changes are all great.

@Myoldmopar
Copy link
Member

This one still seems happy locally. Let's get it merged in. Thanks @mjwitte and @JasonGlazer

@Myoldmopar Myoldmopar merged commit c2f83e3 into develop Feb 3, 2025
9 checks passed
@Myoldmopar Myoldmopar deleted the addSpaceColumnsToEnvelopeSummary branch February 3, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants