Skip to content

Conversation

@jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jan 27, 2025

Pull request overview

99.99% sure it's cruft. Can't find a single mention of it in the codebase, it was added with the initial commit of E+ on this repo, and touched twice (by people who use grep and found it).

https://github.com/NREL/EnergyPlusArchive/blob/92ffc69755ab1ed2315a7a49a9b04fb000aecb25/Release%20Utilities%20-%20Licenses/LinuxInstall/AnnotatedDirectoryStructure.txt#L66-L70

|-- example
| |-- inputs
| | |-- 0_readme.txt (includes script to run all the distributed example files)

just use the "emall.list" in the Scriptmaker StarTeam folder and prepend "runenergyplus "
All input files are here (will be part of the distribution).

@Myoldmopar said it's obsolete last september 2024: #10770 (comment)

And in 2022: #9681 (comment)

And it was kinda said already in 2014: #4369 (comment)

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added DoNotPublish Includes changes that shouldn't be reported in the changelog Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Jan 27, 2025
@jmarrec jmarrec requested review from Myoldmopar and mjwitte January 27, 2025 08:26
@jmarrec jmarrec self-assigned this Jan 27, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye

Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmarrec ! Buh-bye emall.

@mjwitte mjwitte merged commit aaa76f4 into develop Jan 27, 2025
8 checks passed
@mjwitte mjwitte deleted the remove_emall branch January 27, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants