Skip to content

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Dec 12, 2024

Pull request overview

  • Fix a bad copy/paste error in the WaterToAirHeatPumps.idf dataset

Here's screenshot from the manufacturer data used to generate the dataset:
image
Source: https://www.climatemaster.com/download/18.274be999165850ccd5b5c48/1535543869128/lc517-climatemaster-commercial-tranquility-compact-belt-drive-tchv-series-water-source-heat-pump-submittal-set.pdf

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation labels Dec 12, 2024
@lymereJ lymereJ added this to the EnergyPlus 25.1 IO Freeze milestone Dec 12, 2024
@nrel-bot-2
Copy link

@lymereJ it has been 9 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

5 similar comments
@nrel-bot-2
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@lymereJ it has been 7 days since this pull request was last updated.

@Myoldmopar Myoldmopar merged commit 67c1da8 into develop Feb 3, 2025
11 checks passed
@Myoldmopar Myoldmopar deleted the fix_type_wahp_dataset branch February 3, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants