Fix Meter:Custom with mix of valid and invalid names #10773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
amirroth
commented
Sep 27, 2024
| // Has to be a summed variable | ||
| if (srcDDVar->storeType != StoreType::Sum) { | ||
| ShowWarningCustomMessage(state, | ||
| ShowWarningCustomMessage(state, // Is clang-format formatting things like this? This is gross. |
Collaborator
Author
There was a problem hiding this comment.
Seriously, clang-format is not worth it if this is the result.
| ipsc->cAlphaFieldNames(fldIndex + 1), | ||
| ipsc->cAlphaArgs(fldIndex + 1))); | ||
| ShowContinueError(state, "...will not be shown with the Meter results."); | ||
| foundBadSrc = true; |
Collaborator
Author
There was a problem hiding this comment.
One line fix. A missing component variable/meter no longer sets an error condition that prevents the custom meter from being created.
Collaborator
Author
|
@mjwitte, you've already fixed one of my bugs. You shouldn't have to fix all of them. |
Myoldmopar
approved these changes
Sep 30, 2024
| ipsc->cAlphaFieldNames(fldIndex + 1), | ||
| ipsc->cAlphaArgs(fldIndex + 1))); | ||
| ShowContinueError(state, "...will not be shown with the Meter results."); | ||
| foundBadSrc = true; |
Member
|
Test fine with latest develop pulled in, going in. Thanks @amirroth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10384 changed the behavior of
Meter:Customso that meter creation fails if one of the component variables or meters is missing. According to issue #10771, the desired behavior is to create the custom meter but ignore the missing component variable or meter. This behavior was restored.