Skip to content

Fix Convective Baseboard with Hard Sizes #10772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myoldmopar merged 1 commit into from
Sep 30, 2024
Merged

Fix Convective Baseboard with Hard Sizes #10772

Myoldmopar merged 1 commit into from
Sep 30, 2024

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Sep 27, 2024 •
edited by rraustad
Loading

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 27, 2024
@mjwitte mjwitte changed the title Baseboard sizing adjustments Fix Convective Baseboard with Hard Sizes Sep 27, 2024
rraustad
rraustad reviewed Sep 27, 2024
View reviewed changes
src/EnergyPlus/BaseboardRadiator.cc
}
} else {
auto &zoneEqSizing = state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum);
auto const &finalZoneSizing = state.dataSize->FinalZoneSizing(state.dataSize->CurZoneEqNum);
Copy link
Contributor

@rraustad rraustad Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why I keep missing these allocation issues. Even here this doesn't look right. At this else, the flow could be autosized and a zone sizing run might not be requested. I think there needs to be a CheckZoneSizing call here to fatal out before the sizing arrays are accessed.

if (!FlowAutoSize && !state.dataSize->ZoneSizingRunDone) {
} else {
    std::string_view const CompType = cCMO_BBRadiator_Water;
    std::string_view const CompName = this->EquipID;
    CheckZoneSizing(state, CompType, CompName);
    // now OK to access sizing arrays
    auto &zoneEqSizing = state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum);
    auto const &finalZoneSizing = state.dataSize->FinalZoneSizing(state.dataSize->CurZoneEqNum);

Copy link
Contributor Author

@mjwitte mjwitte Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several CheckZoneSizing calls were removed in #10721 and consolidated in the precheck function which is now called checkForZoneSizing.

Copy link
Contributor

@rraustad rraustad Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. And these references still need to be located where sizing is requested so this is good.

@mjwitte mjwitte added this to the EnergyPlus 24.2 milestone Sep 27, 2024
@rraustad
Copy link
Contributor

rraustad commented Sep 28, 2024

I tried to break this without success. The closest I got was reporting baseboard sizing when a Sizing:Plant object exists and otherwise not reporting that data. Since the UA and water flow rate are hard sized this is probably not a big deal. I don't think there is anything to do here so just documenting the fact that several variations of inputs were tested and passed.

ZoneHVAC:Baseboard:Convective:Water,
  Zone1Baseboard,          !- Name
  FanAndCoilAvailSched,    !- Availability Schedule Name
  Zone1BBHWInletNode,      !- Inlet Node Name
  Zone1BBHWOutletNode,     !- Outlet Node Name
  CapacityPerFloorArea,   !- Heating Design Capacity Method
  autosize,                !- Heating Design Capacity {W}
  50.,                        !- Heating Design Capacity Per Floor Area {W/m2}
  1.2,                        !- Fraction of Autosized Heating Design Capacity
  500.,                    !- U-Factor Times Area Value {W/K}
  0.0012,                  !- Maximum Water Flow Rate {m3/s}
  0.001;                   !- Convergence Tolerance

TryToBreak-in.idf.txt

rraustad
rraustad approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sound. Unit test shows expected severe/fatal.

@Myoldmopar
Copy link
Member

Myoldmopar commented Sep 30, 2024

Documentation issue is obviously unrelated. I'm doing a quick build locally to verify things.

@Myoldmopar
Copy link
Member

Myoldmopar commented Sep 30, 2024

This one is also happy locally, let's get this in as well. Thanks for this one @mjwitte

@Myoldmopar Myoldmopar merged commit 76fb9f8 into develop Sep 30, 2024
@Myoldmopar Myoldmopar deleted the fix10769hardsizeBaseboard branch September 30, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rraustad rraustad rraustad approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 24.2

Development

Successfully merging this pull request may close these issues.

EnergyPlus 24.2 produces zero heating energy for hardsized baseboard

8 participants

@mjwitte @rraustad @Myoldmopar @nrel-bot @nrel-bot-2 @nrel-bot-2b @nrel-bot-2c